Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-worker: split out gRPC connection handling #552

Merged
merged 1 commit into from Aug 23, 2021
Merged

nfd-worker: split out gRPC connection handling #552

merged 1 commit into from Aug 23, 2021

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 8, 2021

Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2021

This PR is targeting #525. There are other ways (probably better and more extensive) to make the code re-usable. But, this was a quick one that I came up with in the limited time I had.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@swatisehgal swatisehgal mentioned this pull request Jul 13, 2021
Merged
swatisehgal pushed a commit to swatisehgal/node-feature-discovery that referenced this pull request Jul 13, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
8a46267 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to swatisehgal/node-feature-discovery that referenced this pull request Jul 13, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
a0bb289 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to k8stopologyawareschedwg/node-feature-discovery that referenced this pull request Jul 13, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
0711162 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to k8stopologyawareschedwg/node-feature-discovery that referenced this pull request Jul 13, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
06bf516 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to k8stopologyawareschedwg/node-feature-discovery that referenced this pull request Jul 13, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
10c8f5a 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to k8stopologyawareschedwg/node-feature-discovery that referenced this pull request Jul 13, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
7e074e9 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to swatisehgal/node-feature-discovery that referenced this pull request Jul 19, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
b8c3a83 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to k8stopologyawareschedwg/node-feature-discovery that referenced this pull request Aug 10, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
18325d7 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to swatisehgal/node-feature-discovery that referenced this pull request Aug 20, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
a5e026e 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal pushed a commit to k8stopologyawareschedwg/node-feature-discovery that referenced this pull request Aug 20, 2021
@marquiz @swatisehgal
nfd-worker: split out gRPC connection handling
43a56b7 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.

Code Cherry-picked from PR: kubernetes-sigs#552

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@marquiz
nfd-worker: split out gRPC connection handling
112744b 
Refactor the worker code and split out gRPC client connection handling
into a separate base type. The intent is to promote re-usability of code
for other NFD clients, too.
@marquiz
Copy link
Contributor Author

marquiz commented Aug 20, 2021

Rebased.

Any comments @swatisehgal? This is targeting your work so we could merge this if you see it good and useful

@marquiz marquiz added this to the v0.10.0 milestone Aug 20, 2021
@swatisehgal
Copy link
Contributor

Thanks for the PR @marquiz. This change looks good to me!I have it already cherry-picked in my PR: #525.

ArangoGutierrez
ArangoGutierrez approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Aug 23, 2021

Thanks for the PR @marquiz. This change looks good to me!I have it already cherry-picked in my PR: #525.

Thanks @swatisehgal
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit a20c887 into kubernetes-sigs:master Aug 23, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Aug 23, 2021

We can improve on the code re-use later on, if needed

@marquiz marquiz deleted the devel/worker-refactor branch August 23, 2021 12:58
@marquiz marquiz mentioned this pull request Dec 22, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marquiz @swatisehgal @k8s-ci-robot @ArangoGutierrez