Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/iommu: deprecate and disable by default #677

Merged
merged 2 commits into from Jan 5, 2022
Merged

source/iommu: deprecate and disable by default #677

merged 2 commits into from Jan 5, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Nov 26, 2021

Deprecate the iommu source and disable it by default.

First step of #676

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2021
@ArangoGutierrez ArangoGutierrez mentioned this pull request Dec 7, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2021
@marquiz marquiz mentioned this pull request Dec 17, 2021
Closed
@ArangoGutierrez
Copy link
Contributor

/test all

@ArangoGutierrez
Copy link
Contributor

@marquiz rebase ;P

@marquiz
source: rename TestSource to SupplementalSource
a6eddba 
Just widen the scope in terms of naming, to cover deprecated and/or
experimental sources too, for example.
@marquiz
source/iommu: deprecate and disable by default
838a375 
Deprecate the iommu source and disable it by default.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Dec 20, 2021

Rebased

@marquiz marquiz mentioned this pull request Dec 21, 2021
Merged
@marquiz marquiz added this to the v0.10.0 milestone Dec 22, 2021
@ArangoGutierrez
Copy link
Contributor

/test all

ArangoGutierrez
ArangoGutierrez approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1567900 into kubernetes-sigs:master Jan 5, 2022
@marquiz marquiz deleted the devel/iommu-deprecation branch January 7, 2022 11:38
@marquiz marquiz mentioned this pull request Jan 10, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marquiz @ArangoGutierrez @k8s-ci-robot