Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change label namespace #71

Closed

Conversation

andyxning
Copy link
Contributor

Change nfd label to nfd.alpha.kubernetes.io according to Kubernetes Community #300 when in alpha phase.

How about we change nfd namespace according to nfd available phase like below:

  • alpha
    • nfd.alpha.kubernetes.io
  • beta
    • nfd.beta.kubernetes.io
  • GA(graduate from incubator)
    • nfd.kubernetes.io

/cc @balajismaniam @ConnorDoyle @davidopp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2017
@ConnorDoyle
Copy link
Contributor

ConnorDoyle commented Aug 30, 2017

I can get to this post v1.8

@ConnorDoyle
Copy link
Contributor

I'm not totally convinced that we need to evolve the alpha names, but the pattern for beta and GA proposed here look great. Could you start a tracking issue for graduation to beta that includes the beta naming scheme? Then we can get momentum moving towards graduating this repo.

cc @balajismaniam for another opinion here

@andyxning
Copy link
Contributor Author

andyxning commented Sep 6, 2017

@ConnorDoyle @balajismaniam @dchen1107

The reason for using nfd as the subdomain name as kubernetes.io in alpha, beta and GA is mainly:

  • more smaller and at the same time it is also clear that it represents node-feature-discovery. Smaller labels is more friendly to ETCD.
  • the unification of alpha, beta and GA is mainly to keep the subdomain clearly targeted for node-feature-discovery. Maybe it is just a placeholder for alpha.

I also suggest we add node-feature-discovery labels schema to the well-known kubernetes labels once we make an agreement on this.

@ConnorDoyle
Copy link
Contributor

I guess my concern is adding unnecessary label churn beyond what's required by alpha => beta and beta => ga. On board with picking up the convention upon move to beta. I don't think it's worthwhile to rev the naming scheme before that.

@andyxning
Copy link
Contributor Author

Could you start a tracking issue for graduation to beta that includes the beta naming scheme? Then we can get momentum moving towards graduating this repo.

Will fire an issue to track the jobs we need to do for a beta release later.

@andyxning andyxning mentioned this pull request Sep 6, 2017
8 tasks
@andyxning
Copy link
Contributor Author

@ConnorDoyle I have added an issue #74 and list something i think we need to do before we reach beta release. PTAL.

@balajismaniam
Copy link
Contributor

I agree with @ConnorDoyle. We should not change label namespaces before graduating to beta. Moreover, moving to kubernetes.io namespace might require discussion with the community. I like the label conventions mentioned for beta and GA.

@andyxning
Copy link
Contributor Author

@balajismaniam Agree on moving to kubernetes.io namespace might require discussion with the community.. What about send an email to kubernetes-sig-node and cc sponsor @dchen1107 and champion @davidopp .

@balajismaniam
Copy link
Contributor

Closing this for now. Let's wait till beta to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants