-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change label namespace #71
Conversation
I can get to this post v1.8 |
I'm not totally convinced that we need to evolve the alpha names, but the pattern for beta and GA proposed here look great. Could you start a tracking issue for graduation to beta that includes the beta naming scheme? Then we can get momentum moving towards graduating this repo. cc @balajismaniam for another opinion here |
@ConnorDoyle @balajismaniam @dchen1107 The reason for using
I also suggest we add node-feature-discovery labels schema to the well-known kubernetes labels once we make an agreement on this. |
I guess my concern is adding unnecessary label churn beyond what's required by alpha => beta and beta => ga. On board with picking up the convention upon move to beta. I don't think it's worthwhile to rev the naming scheme before that. |
Will fire an issue to track the jobs we need to do for a beta release later. |
@ConnorDoyle I have added an issue #74 and list something i think we need to do before we reach beta release. PTAL. |
I agree with @ConnorDoyle. We should not change label namespaces before graduating to beta. Moreover, moving to |
@balajismaniam Agree on |
Closing this for now. Let's wait till beta to change this. |
Change nfd label to
nfd.alpha.kubernetes.io
according to Kubernetes Community #300 when in alpha phase.How about we change nfd namespace according to nfd available phase like below:
nfd.alpha.kubernetes.io
nfd.beta.kubernetes.io
nfd.kubernetes.io
/cc @balajismaniam @ConnorDoyle @davidopp