Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-0.10: enable multi arch builds #743

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jan 21, 2022

Enables multi arch (amd64 and arm64) builds on the release-0.10 branch. Done by cherry-picking required commits from master.

zvonkok and others added 9 commits January 21, 2022 10:50
(cherry picked from commit c69e47a)
(cherry picked from commit 8414fe8)
This patch increases the timeout when setting up the NFD master
to 5 seconds instead of 1 second to allow for running tests in
slow environments.

(cherry picked from commit cf1bc4a)
Re-introduce docker authentication that was dropped in
bac6908. Should fix issues with
building multi-arch buildx buildx.

(cherry picked from commit 33cfd6e)
Hopefully speeds up our multi-arch builds.
Multiarch builds take considerably longer than the default (10 min)
allows.

(sync with commit e674631)
@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2022
@marquiz marquiz mentioned this pull request Jan 21, 2022
22 tasks
@zvonkok
Copy link
Contributor

zvonkok commented Jan 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
(cherry picked from commit 7e1f5cb)
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/test pull-node-feature-discovery-build-image

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

pull-node-feature-discovery-build-image-cross

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022
@zvonkok
Copy link
Contributor

zvonkok commented Jan 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit f6e553f into kubernetes-sigs:release-0.10 Jan 21, 2022
@marquiz marquiz deleted the devel/release-0.10-multiarch branch January 21, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants