Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: add cpuid stub for non-linux platforms #808

Merged
merged 1 commit into from May 11, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Apr 14, 2022

Make it possible to do non-linux builds. Code compiles, at least, even
if the feature detection functionality is virtually Linux-only.

Make it possible to do non-linux builds. Code compiles, at least, even
if the feature detection functionality is virtually Linux-only.
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Apr 14, 2022

#803

@marquiz marquiz force-pushed the devel/darwin branch 2 times, most recently from 0eb044c to d50797c Compare April 14, 2022 18:55
@marquiz marquiz marked this pull request as ready for review April 14, 2022 18:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Apr 14, 2022

@mathuvenkat can you verify/confirm that this fixes your issue (on darwin/arm64).
/assign @ArangoGutierrez

@ArangoGutierrez
Copy link
Contributor

@mathuvenkat can you verify/confirm that this fixes your issue (on darwin/arm64). /assign @ArangoGutierrez

I have 2 Linux machines at home ;P , going to ask for a friend to test this out on Mac and report back later this week

@wabouhamad
Copy link

@ArangoGutierrez make build completed successfully on Mac A1 and the 3 binaries are produced:
uname -a
Darwin -mac 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64

In node-feature-discovery/bin
$ ls -ltr
total 193880
-rwxr-xr-x 1 <my_user> staff 20466992 May 11 09:00 nfd-worker
-rwxr-xr-x 1 <my_user> staff 38640480 May 11 09:00 nfd-master
-rwxr-xr-x 1 <my_user> staff 40156752 May 11 09:00 nfd-topology-updater

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented May 11, 2022

Thanks @ArangoGutierrez
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 869c7cd into kubernetes-sigs:master May 11, 2022
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
@marquiz marquiz deleted the devel/darwin branch February 21, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants