Improve GoReportCard metrics, both gofmt and golint #90
Conversation
k8s-ci-robot
added
cncf-cla: yes
okartau
force-pushed
the
improve-go-format
branch
from
4e22d06
to
a0a2910
Compare
k8s-ci-robot
added
size/S
okartau
changed the title
mockapihelpers.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
| api "k8s.io/client-go/pkg/api/v1" | |||
| ) | |||
|
|
|||
| // MockAPIHelpers for testing support | |||
There was a problem hiding this comment.
This file is auto-generated. Making manual changes to auto-generated files is not recommended. Please revert this change.
mockfeaturesource.go
Outdated
| @@ -2,6 +2,7 @@ package main | |||
|
|
|||
| import "github.com/stretchr/testify/mock" | |||
|
|
|||
| // MockFeatureSource for testing support | |||
There was a problem hiding this comment.
This file is auto-generated. Making manual changes to auto-generated files is not recommended. Please revert this change.
source/fake/fake.go
Outdated
| @@ -19,13 +19,15 @@ package fake | |||
| // Source implements FeatureSource. | |||
| type Source struct{} | |||
|
|
|||
| // Name returns a friendly name for this source. | |||
There was a problem hiding this comment.
Maybe change this description to Name returns a identifier string for this feature source?
source/network/network.go
Outdated
| ) | ||
|
|
||
| // Source implements FeatureSource. | ||
| type Source struct{} | ||
|
|
||
| // Name returns a friendly name for this source. |
There was a problem hiding this comment.
Maybe change this description to Name returns a identifier string for this feature source?
source/panic_fake/fake_panic.go
Outdated
| @@ -19,8 +19,10 @@ package panic_fake | |||
| // Source implements FeatureSource. | |||
| type Source struct{} | |||
|
|
|||
| // Name returns a friendly name for this source. | |||
There was a problem hiding this comment.
Maybe change this description to Name returns a identifier string for this feature source?
source/pstate/pstate.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| // Source implements FeatureSource. | |||
| type Source struct{} | |||
|
|
|||
| // Name returns a friendly name for this source. | |||
There was a problem hiding this comment.
Maybe change this description to Name returns a identifier string for this feature source?
source/rdt/rdt.go
Outdated
| @@ -31,9 +31,10 @@ const ( | |||
| // Source implements FeatureSource. | |||
| type Source struct{} | |||
|
|
|||
| // Name returns a friendly name for this source. | |||
There was a problem hiding this comment.
Maybe change this description to Name returns a identifier string for this feature source?
okartau
force-pushed
the
improve-go-format
branch
from
b8baef6
to
87d6393
Compare
|
I made proposed changes. I used "an identifier" as this seems grammatically more correct. |
|
Thanks for making these changes. During linting there are ways to ignore files if required. Also fair point on the changes to those mock files in #102. If you add back the changes you made earlier, I can re-approve it. |
|
@okartau Any updates on this? |
Order of import changed in main.go and network.go, missing ending newline added in fake.go
Mostly about missing or incomplete comments
okartau
force-pushed
the
improve-go-format
branch
from
87d6393
to
4003367
Compare
|
rebased and force pushed, should be up to date now |
Adding a note that these files are auto-generated, including instructions how to re-generate these files. Rename the files, using the defaults provided by the mockery tool, in order to make their generation easier.
|
PR #141 is aiming at resolving this |
Adding a note that these files are auto-generated, including instructions how to re-generate these files. Rename the files, using the defaults provided by the mockery tool, in order to make their generation easier.
Adding a note that these files are auto-generated, including instructions how to re-generate these files. Rename the files, using the defaults provided by the mockery tool, in order to make their generation easier.
Order of import changed in main.go and network.go,
missing ending newline added in fake.go
[warm-up exercise as just starting with this project. This change is expected to set gofmt metrics to 100%]