-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export proxy env vars inside docker build #91
Export proxy env vars inside docker build #91
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
b2a9168
to
77d0fc0
Compare
@@ -12,4 +12,10 @@ all: docker | |||
# QUAY_REGISTRY_USER=<my-username> make docker -e. | |||
docker: | |||
docker build --build-arg NFD_VERSION=$(VERSION) \ | |||
--build-arg http_proxy=$(http_proxy) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this change is required. Usually developers use software mechanisms to bypass firewall and proxy settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see that this change would cause some problems? There are developers, like me, who do not use these software mechanisms or do not want to deploy those in every development environment. These proxy settings are ubiquitous all over kubernetes so why couldn't nfd build support these, as well?
77d0fc0
to
c2e7829
Compare
c2e7829
to
f316f7a
Compare
1bbb109
to
4b53f0b
Compare
ping @balajismaniam, any further comments? |
4b53f0b
to
3be801b
Compare
/retest |
Without correct proxy settings propagated to docker build it is not possible to build node-feature-discovery from behind a proxy server, e.g. in corporate networks. This patch fixes the issue by exporting all http(s) proxy related environment variables as build-time variables.
3be801b
to
bb32ef8
Compare
ping @balajismaniam! This is biting me all the time |
Without correct proxy settings propagated to docker build it is not possible to
build node-feature-discovery from behind a proxy server, e.g. in corporate
networks. This patch fixes the issue by exporting all http(s) proxy related
environment variables as build-time variables.