pkg/names: test namespaced external metrics selectors

pkg/naming/metrics_query_test.go

@@ -34,7 +34,7 @@ type resourceConverterMock struct {
 // ResourcesForSeries is a mock that returns a single group resource,
 // namely the series as a resource itself.
 func (rcm *resourceConverterMock) ResourcesForSeries(series prom.Series) (res []schema.GroupResource, namespaced bool) {
-	return []schema.GroupResource{{Resource: series.Name}}, false
+	return []schema.GroupResource{{Resource: series.Name}}, rcm.namespaced
 }
 
 // LabelForResource is a mock that returns the label name,
@@ -300,6 +300,19 @@ func TestBuildExternalSelector(t *testing.T) {
 				hasSelector("[foo bar]"),
 			),
 		},
+		{
+			name: "multiple GroupBySlice values with namespace",
+
+			mq:             mustNewQuery(`<<index .LabelValuesByName "namespaces">> <<.GroupBySlice>>`, true),
+			namespace:      "default",
+			groupBySlice:   []string{"foo", "bar"},
+			metricSelector: labels.NewSelector(),
+
+			check: checks(
+				hasError(nil),
+				hasSelector("default [foo bar]"),
+			),
+		},
 		{
 			name: "single LabelMatchers value",
 
@@ -313,6 +326,20 @@ func TestBuildExternalSelector(t *testing.T) {
 				hasSelector(`foo="bar"`),
 			),
 		},
+		{
+			name: "single LabelMatchers value with namespace",
+
+			mq:        mustNewQuery(`<<.LabelMatchers>>`, true),
+			namespace: "default",
+			metricSelector: labels.NewSelector().Add(
+				*mustNewLabelRequirement("foo", selection.Equals, []string{"bar"}),
+			),
+
+			check: checks(
+				hasError(nil),
+				hasSelector(`foo="bar",namespaces="default"`),
+			),
+		},
 		{
 			name: "multiple LabelMatchers value",