Fix segfault when using --prometheus-token-file #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
olivierlemasle
force-pushed
the
fix-token-file
branch
from
7ffceeb
to
e740fee
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, JoaoBraveCoding, olivierlemasle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
monitoring-commit-bot bot
pushed a commit
to rhobs/k8s-prometheus-adapter
that referenced
this pull request
Aug 10, 2023
Changes since v0.10.0 Logging flags that are klog specific (`--log-dir`, `--log-file`, `--logtostderr`, `--alsologtostderr`, `--one-output`, `--stderrthreshold`, `--log-file-max-size`, `--skip-log-headers`, `--add-dir-header`, `--skip-headers`, `--log-backtrace-at`) were deprecated in v0.10.0 and are now **removed**. Improvements * Bump go to 1.20 and k8s deps to 0.27.2 (kubernetes-sigs#586, @dgrisonnet) * Add support for OpenAPI v3 (kubernetes-sigs#586, @dgrisonnet) * Update registry location to registry.k8s.io in the manifests (kubernetes-sigs#529, @dgrisonnet) * Update manifests in deploy/manifests to be in sync with the one in kube-prometheus (kubernetes-sigs#531, @JoaoBraveCoding) * Use golangci-lint to lint the codebase (kubernetes-sigs#540, @olivierlemasle) * Set MinVersion: tls.VersionTLS12 in prometheus client's TLSClientConfig (kubernetes-sigs#544, @olivierlemasle) * Refactor adding logging flags (kubernetes-sigs#546, @olivierlemasle) Bug fixes * Fix segfault when using --prometheus-token-file (kubernetes-sigs#538, @olivierlemasle) Documentation * Fix broken links in README.md (kubernetes-sigs#518, @sillyfrog) * Fix yaml in sample config & docs (kubernetes-sigs#559, @asherf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--prometheus-token-fileis used, prometheus-adapter crashes with a segmentation violation errorThis is caused by
httpClient.Transportbeingniland being dereferenced in theBearerAuthRoundTripper.Fixes #478