Abstract a request counter's cycle logic from watch() #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
tylerferrara
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
tylerferrara
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
tylerferrara
changed the title
listx
reviewed
Jul 29, 2021
This was referenced Jul 30, 2021
Closed
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Thanks! /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx, tylerferrara The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
This change separates sleep/log cycles from the
watch()function withinreqcounter. Abstracting this repeated logic from watch's anonymous goroutine allows for simple deterministic testing of sleep/log behavior. Now there is no need toTestWatch(#372), as it simply executes Cycle() indefinitely.Which issue(s) this PR fixes:
Partially satisfies #358
Special notes for your reviewer:
This approach is much more favorable than previous attempts to test the logging of request counters. Since request counters spawn goroutines in
watch(), advancing time forward involves complicated synchronization patterns to ensure a sleep/log cycle has finished. Instead, if we only test sleep/log behavior, we avoid unwanted complexity while still resulting in equivalent code coverage.Supersedes: #372 #368 #369
Does this PR introduce a user-facing change?
NONE
cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering