Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Issue Org Invitations #180

Open
jberkus opened this issue May 31, 2024 · 1 comment
Open

Feature Request: Issue Org Invitations #180

jberkus opened this issue May 31, 2024 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@jberkus
Copy link

jberkus commented May 31, 2024

Migrated from the original issue.

What would you like to be added: It would be nice to have trigger include a bold, explicit invitation to join the org in its ok-to-test message after you've made a three PRs (that is, on your fourth), sample message:

We noticed you've done this a few times! Consider joining the Kubernetes org to skip this step, as well as gain LGTM and other bot rights rights. We recommend asking the approvers on your prior PRs to be your sponsors.

We can do a query like type:pr is:merged org:kubernetes author:$user before making the comment to determine if someone is qualified - this graphql query has a flat cost of 1:

query {
  search(query: "type:pr is:merged org:kubernetes author:katharine", type: ISSUE) {
    issueCount
  }
}

Alternatively, we can just always comment and leave the user to figure out whether they count, but I think this diminishes the effectiveness over a positive assertion.

If there are issues with doing a count over the whole org, then doing it just on the current repository would be adequate.

Why is this needed: Joining the org is pretty intimidating. On top of that, it is wildly unclear when people are eligible to join, and even if they clearly are, it often doesn't occur to them to actually do so. An estimated 1/3 of our regular contributors are not org members. While this doesn't help contributors who do not make PRs who would be eligible for org membership, it would be helpful to those who do. The real bar is much lower than non-members tend to think it is.

We currently mention that "regular contributors should join the org to skip this step", but it's not at all noticeable and "regular contributors" is wildly open to interpretation.

(shoutout to @liztio for the concept, and @Katharine for the original writeup)

/kind feature
/sig contributor-experience
/priority backlog
/help

@k8s-ci-robot
Copy link
Contributor

@jberkus:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Migrated from the original issue.

What would you like to be added: It would be nice to have trigger include a bold, explicit invitation to join the org in its ok-to-test message after you've made a three PRs (that is, on your fourth), sample message:

We noticed you've done this a few times! Consider joining the Kubernetes org to skip this step, as well as gain LGTM and other bot rights rights. We recommend asking the approvers on your prior PRs to be your sponsors.

(It would also be nice if we had a document to link to that wasn't all about reasons you can't be a member...)

We can do a query like type:pr is:merged org:kubernetes author:$user before making the comment to determine if someone is qualified - this graphql query has a flat cost of 1:

query {
  search(query: "type:pr is:merged org:kubernetes author:katharine", type: ISSUE) {
    issueCount
  }
}

Alternatively, we can just always comment and leave the user to figure out whether they count, but I think this diminishes the effectiveness over a positive assertion.

If there are issues with doing a count over the whole org, then doing it just on the current repository would be adequate.

Why is this needed: Joining the org is pretty intimidating. On top of that, it is wildly unclear when people are eligible to join, and even if they clearly are, it often doesn't occur to them to actually do so. An estimated 1/3 of our regular contributors are not org members. While this doesn't help contributors who do not make PRs who would be eligible for org membership, it would be helpful to those who do. The real bar is much lower than non-members tend to think it is.

We currently mention that "regular contributors should join the org to skip this step", but it's not at all noticeable and "regular contributors" is wildly open to interpretation.

(shoutout to @liztio for the concept, and @Katharine for the original writeup)

/kind feature
/sig contributor-experience
/priority backlog
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. priority/backlog Higher priority than priority/awaiting-more-evidence. labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

2 participants