New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build images using cloudbuild #123
build images using cloudbuild #123
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.gcloudignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an empty .gcloudignore allows GCB to upload the .git
folder which is required by hack/prowimagebuilder
to run git commands to fetch git status.
fe1c39e
to
df22dd1
Compare
To my understanding, #113 states that we should attempt to promote prow components to |
#113 requires Prow maintainers to start versioning prow and promote the release images to registry.k8s.io. In the meanwhile, we need to be able to publish and consume unversioned prow images from an AR registry called |
The location of the prow components is not a hard requirement to bootstrap a cluster for prow and we specially don't need to co-locate a AR registry and a GKE cluster. |
Pricing is the same for both storage and bandwidth. https://cloud.google.com/artifact-registry/pricing#storage
I'm doing this for convenience. Prow images are a special case and will need to be stored for more than 60 days(how long is TBD) and AR has a good security boundary, unlike GCR which interacts with GCS so a dedicated staging project makes no sense. The approach in k8s-prow where the cluster and images are in the project works for us. |
/approve |
currently
They shouldn't be. Which other projects would we special-case? The only special case I know currently is registry.k8s.io because we would have a circular dependency problem. |
df22dd1
to
d3a7f94
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, matthyx, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Part of #113
Part of kubernetes/k8s.io#6740
Right now, our postsubmit job runs in a pod which breaks our trusted cluster build policies.
I tested this build at https://console.cloud.google.com/cloud-build/builds;region=global/ce637e5c-b605-490f-b104-589b7dca23c6?project=k8s-infra-ii-sandbox
@BenTheElder @ameukam