Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assign plugins #206

Closed

Conversation

Okabe-Junya
Copy link
Member

this PR is following up to #164

Bug Description

ListTeamMembersBySlug function requires org and teamSlug as arguments, but I mistakenly passed org and login as arguments.

teamMembers, err := h.gc.ListTeamMembersBySlug(org, login, "all")

Meaning, I was passing arguments like kubernetes, kubernetes/sig-misc-approvers - The correct arguments are kubernetes, sig-misc-approvers

Change List

  • Split the login into org and teamSlug before passing them to the function

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Okabe-Junya
Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2024
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit efa0c90
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6686e74ac96b240008b403b0
😎 Deploy Preview https://deploy-preview-206--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member Author

/assign droslean

@droslean
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 11, 2024
@droslean
Copy link
Contributor

@Okabe-Junya Is this the fix for #204 ?

@Okabe-Junya
Copy link
Member Author

@droslean

It's not certain, but since this code clearly contains a bug, I think it's a good to move this PR forward.

ref. #204 (comment)

@droslean
Copy link
Contributor

@Okabe-Junya It would be better to revert the whole feature and you can open another PR to re-introduce it with the fix as well.

@droslean
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@Okabe-Junya
Copy link
Member Author

Ok, closing this PR and create another one

/close

@k8s-ci-robot
Copy link
Contributor

@Okabe-Junya: Closed this PR.

In response to this:

Ok, closing this PR and create another one

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Okabe-Junya Okabe-Junya deleted the fix-assign-plugins branch July 11, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants