-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assign plugins #206
Fix assign plugins #206
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Okabe-Junya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign droslean |
/label tide/merge-method-squash |
@Okabe-Junya Is this the fix for #204 ? |
It's not certain, but since this code clearly contains a bug, I think it's a good to move this PR forward. ref. #204 (comment) |
@Okabe-Junya It would be better to revert the whole feature and you can open another PR to re-introduce it with the fix as well. |
/hold |
Ok, closing this PR and create another one /close |
@Okabe-Junya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
this PR is following up to #164
Bug Description
ListTeamMembersBySlug
function requiresorg
andteamSlug
as arguments, but I mistakenly passed org and login as arguments.Meaning, I was passing arguments like
kubernetes, kubernetes/sig-misc-approvers
- The correct arguments arekubernetes, sig-misc-approvers
Change List
login
into org and teamSlug before passing them to the function