-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tackle from Prow Deployment guide #32
Remove Tackle from Prow Deployment guide #32
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
## Manual deployment | ||
|
||
If you do not want to use the `tackle` utility above, here are the manual set of commands tackle will run. | ||
## Deploying prow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
## Deploying prow | |
## Deploying Prow |
/lgtm Remove hold when ready. |
/unhold |
@listx Oh you commented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jihoon-seo, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Indeed... sorry about that! |
* Remove Tackle from Prow Deployment guide * Move Tackle under 'CLI Tools'
(which is a translation of Remove tackle from prow getting started guide kubernetes/test-infra#26754)
since the
tackle
tool is not actively maintained and thus not really supported.we might preserve the doc for
tackle
.(If we choose this option, then it would be good to change the PR title, as it will become the commit message of squashed commit on
main
branch.)FYI:
From my experience of deploying Prow 1) using tackle, and 2) manually,
tackle
created a webhook to my GitHub org, instead of configuring the webhook of the GitHub App that user just created./label tide/merge-method-squash