Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tackle from Prow Deployment guide #32

Conversation

jihoon-seo
Copy link
Contributor

  • Supersedes & closes remove tackle from getting started guide #24
    (which is a translation of Remove tackle from prow getting started guide kubernetes/test-infra#26754)
  • We have 2 options here for this PR:
    • We might cherrypick the first commit ('Remove Tackle from Prow Deployment guide') only,
      since the tackle tool is not actively maintained and thus not really supported.
    • Or, although the tool is not actively maintained and thus not really supported,
      we might preserve the doc for tackle.
      (If we choose this option, then it would be good to change the PR title, as it will become the commit message of squashed commit on main branch.)

FYI:
From my experience of deploying Prow 1) using tackle, and 2) manually,

  • the Prow depolyment guide instructs to create and configure GitHub App,
    tackle created a webhook to my GitHub org, instead of configuring the webhook of the GitHub App that user just created.
  • ... (Some other inconsistency with the guide might exist.)

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 1, 2022
@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit b12841f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6388369f6ce03f00087f26a0
😎 Deploy Preview https://deploy-preview-32--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
## Manual deployment

If you do not want to use the `tackle` utility above, here are the manual set of commands tackle will run.
## Deploying prow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
## Deploying prow
## Deploying Prow

@jihoon-seo jihoon-seo mentioned this pull request Dec 1, 2022
86 tasks
@listx
Copy link
Contributor

listx commented Dec 20, 2022

/lgtm
/approved
/hold

Remove hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2022
@jihoon-seo
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2022
@jihoon-seo
Copy link
Contributor Author

@listx Oh you commented /approved command, not /approve, in turn Prow did not added approved label.. 😅

Copy link
Contributor

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1005b0b into kubernetes-sigs:main Dec 21, 2022
@listx
Copy link
Contributor

listx commented Dec 21, 2022

@listx Oh you commented /approved command, not /approve, in turn Prow did not added approved label.. 😅

Indeed... sorry about that!

cjwagner pushed a commit to cjwagner/prow that referenced this pull request Mar 22, 2024
* Remove Tackle from Prow Deployment guide

* Move Tackle under 'CLI Tools'
@jihoon-seo jihoon-seo deleted the 221201_Remove_Tackle_from_getting_started_guide branch April 16, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants