Fix RemoteTags() method
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the broken method by removing the `--tags` arg. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/release
|
@kubernetes-sigs/release-sdk-maintainers PTAL |
|
we will need a patch release right? |
Yep, and vendor it into k/release to unblock failing tests. |
|
@cpanato the /lgtm did not apply 🤷 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Dec 13, 2022
To incorporate the fix: kubernetes-sigs/release-sdk#141 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
wespanther
pushed a commit
to wespanther/release
that referenced
this pull request
Jun 2, 2023
To incorporate the fix: kubernetes-sigs/release-sdk#141 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Fixing the broken method by removing the
--tagsarg.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
A regression from #136
Does this PR introduce a user-facing change?