Shallow clone variants #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits the CloneOrOpenRepo function to two utility functions to avoid code duplication and expose the options of the clone call. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
mmmh 🤔 |
This commit split the core of the functionality of the CloneOrOpenRepo to a utility function to make it reusable from functions requiring different git options. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit adds Shallow* variants to our clone functions. The goal of these is to enable faster cloning of large repositories. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
|
Found the error. Thank you tests for doing your job 😸 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds
Shallow*variants to our clone functions. These work exactly as their counterparts but perform a shallow (depth 1) clone of repositories to work with large repositories at HEAD more efficiently.The new functions are:
git.ShallowCloneOrOpenRepo()git.ShallowCloneOrOpenGitHubRepo()git.ShallowCleanCloneGitHubRepo()Note that this PR has many lines but at its core, it is the same logic just broken into ever more specific utility functions to reuse our code. The outward-facing functions just invoke the internal ones with a different options set. Roughly:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/assign @saschagrunert @cpanato @xmudrii
Does this PR introduce a user-facing change?