Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add options to preparefork to when you need to configure special things #294

Merged
merged 2 commits into from Dec 22, 2023
Merged

add options to preparefork to when you need to configure special things #294

merged 2 commits into from Dec 22, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 22, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • add options to preparefork to when you need to configure special things

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add options to preparefork to when you need to configure special things

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2023
@cpanato
Copy link
Member Author

cpanato commented Dec 22, 2023

/assign @puerco @xmudrii

@cpanato
update tests
5477ab2 
Signed-off-by: cpanato <ctadeu@gmail.com>
puerco
puerco approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8ebf35 into kubernetes-sigs:main Dec 22, 2023
5 checks passed
@cpanato cpanato deleted the update-preparefork branch December 22, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco puerco approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@puerco puerco

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpanato @k8s-ci-robot @puerco @xmudrii