-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix NewWithTokenWithClient so it preserves the original http client t… #338
fix NewWithTokenWithClient so it preserves the original http client t… #338
Conversation
…ransport Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
Welcome @rawlingsj! |
Hi @rawlingsj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, rawlingsj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ransport
/kind bug
What this PR does / why we need it:
We recently added a new function that creates a new github client using an existing http client, which people can configure things like a rate limiter. It looks like a new http client is always created when a token is passed. This PR will preserve the transport of the original http client.
Special notes for your reviewer:
Does this PR introduce a user-facing change?