Fix controller reconcile PodGroup status #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
denkensk
reviewed
Dec 8, 2021
lianghao208
force-pushed
the
pod_group_reconcile
branch
from
84d2375
to
abbb781
Compare
k8s-ci-robot
added
size/M
lianghao208
force-pushed
the
pod_group_reconcile
branch
2 times, most recently
from
0666256
to
4ab280f
Compare
k8s-ci-robot
added
size/S
lianghao208
force-pushed
the
pod_group_reconcile
branch
from
4ab280f
to
397a7f2
Compare
|
@denkensk Thank you for the review, I've updated the changes, PTAL. |
denkensk
reviewed
Dec 10, 2021
Signed-off-by: lianghao208 <302824716@qq.com>
lianghao208
force-pushed
the
pod_group_reconcile
branch
from
397a7f2
to
da8c3d1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @Huang-Wei Pls take a look again |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: denkensk, lianghao208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #166
It will be 3 final state of pod group: Failed, Finished, Pending.
Pending means:
Failed means:
at least one of
spec.minMemberpods is failed.Finished means:
all of
spec.minMemberpods are successfully./cc @Huang-Wei @cwdsuzhou @denkensk