Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump master to 1.19 #45

Merged
merged 6 commits into from
Sep 4, 2020

Conversation

Huang-Wei
Copy link
Contributor

@Huang-Wei Huang-Wei commented Aug 29, 2020

  • update go module
    • go version to 1.15
    • klog to v2
    • k8s deps to v1.19.0
  • versioned CoschedulingArgs
    • ensure config API's GVK aligned with in-tree ComponentConfig API
    • API, codegen and CI scripts
  • core logic adapted to new interfaces of scheduler in 1.19
    • adapting logic to new SharedSnapshotLister interface
  • verify tests work
    • UT and Integration test works with the trick of enforcing initialization of scheme pkg
    • manually test CoschedulingArgs to ensure it works in an end-to-end workflow (nil args gets defaulted, and non-default args are horned properly)

- Reuse in-tree scheme to register out-of-tree Args
- A trick to enforce initilization of schem
- Adjust method signature and UT helpers
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 29, 2020
@Huang-Wei Huang-Wei changed the title [WIP] Bump master to 1.19 Bump master to 1.19 Aug 31, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2020
@Huang-Wei
Copy link
Contributor Author

/cc @yuanchen8911 @denkensk This PR is ready fo review.

FYI: @cwdsuzhou

@Huang-Wei
Copy link
Contributor Author

I tried to categorize the changeset into commits. It should be inconvinient to review the code by commits.

@yuanchen8911
Copy link
Member

/cc @yuanchen8911 @denkensk This PR is ready fo review.

FYI: @cwdsuzhou

Will look.

@denkensk
Copy link
Member

denkensk commented Sep 3, 2020

/retest

@denkensk
Copy link
Member

denkensk commented Sep 4, 2020

/lgtm
Thank you for your great work.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit affecd7 into kubernetes-sigs:master Sep 4, 2020
@Huang-Wei Huang-Wei deleted the bump-master-1.19 branch September 8, 2020 17:15
swatisehgal pushed a commit to swatisehgal/scheduler-plugins that referenced this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants