ElasticQuota of Capacity Scheduling Api define #50

denkensk · 2020-09-07T08:52:36Z

Add Capacity Scheduling plugin for the new scheduler framework.
This plugin will be put in kubernetes-sigs/scheduler-plugins firstly.

Kep : #10

xq2005 · 2020-09-09T05:42:31Z

manifests/capacityscheduling/scheduler-config.yaml

+          - name: CapacityScheduling
+      postFilter:
+        enabled:
+          - name: CapacityScheduling


Need to disable the default preemption plugin.

Done thanks ~

denkensk · 2020-09-24T12:37:40Z

/cc @Huang-Wei @yuanchen8911

denkensk · 2020-09-24T12:38:12Z

/cc @xq2005

k8s-ci-robot · 2020-09-24T12:38:13Z

@denkensk: GitHub didn't allow me to request PR reviews from the following users: xq2005.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xq2005

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Huang-Wei · 2020-09-24T22:00:36Z

@denkensk can you split this PR into two sub-PRs? One is the API and codegen, and the second one to cover core logic and tests.

denkensk · 2020-09-25T03:48:09Z

@Huang-Wei

can you split this PR into two sub-PRs? One is the API and codegen, and the second one to cover core logic and tests.

Thanks. I update the pr. It's easy to review.

Huang-Wei

Thanks @denkensk ! Comments below.

manifests/capacityscheduling/capacityscheduling_v1alpha1_elasticquota.yaml

Huang-Wei · 2020-09-25T20:09:51Z

hack/update-codegen.sh

@@ -33,5 +33,5 @@ bash "${CODEGEN_PKG}"/generate-groups.sh \
  all \
  sigs.k8s.io/scheduler-plugins/pkg/generated \
  sigs.k8s.io/scheduler-plugins/pkg/apis \
-  podgroup:v1alpha1 \
-  --go-header-file "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.generatego.txt
+  "podgroup:v1alpha1 capacityscheduling:v1alpha1" \


resourcequota:v1alpha1? In general introduction, we can say we're doing capacity scheduling, however, to make it a concrete concept/API, let's name it resourcequota.

elasticquota?

Yes. elasticquota

Yes, typo...

manifests/capacityscheduling/capacityscheduling_v1alpha1_elasticquota.yaml

manifests/capacityscheduling/scheduler-config.yaml

pkg/apis/capacityscheduling/register.go

Huang-Wei · 2020-09-25T20:24:30Z

pkg/apis/capacityscheduling/v1alpha1/doc.go

@@ -0,0 +1,4 @@
+// +k8s:deepcopy-gen=package
+// +groupName=capacityscheduling.sigs.k8s.io


Suggested change

// +groupName=capacityscheduling.sigs.k8s.io

// +groupName=scheduling.sigs.k8s.io

pkg/apis/capacityscheduling/v1alpha1/register.go

pkg/apis/capacityscheduling/v1alpha1/types.go

Huang-Wei · 2020-09-25T20:34:51Z

pkg/apis/config/v1beta1/types.go

+	metav1.TypeMeta `json:",inline"`
+
+	// KubeConfigPath is the path of kubeconfig.
+	KubeConfigPath string `json:"kubeconfigpath,omitempty"`


nit: make it a *string in versioned pkg, so we can easily set a default value if it's nil; if it's a concrete string, we cannot tell if the zero value ("") is set by users.

In general, we can set the default parameters in default.go for all plugins: CoScheduling, NodeResouresAllocatable, CapacityScheduling.

Something like

func (csa *CapacitySchedulingArgs) SetDefaults() { defaultPath := "/var/lib/kubernetes/kubeconfig" if csa.KubeConfigPath == nil { csa.KubeConfigPath = &defaultPath } ...

We can then validate the parameters in validation.go.

// Validate checks and verifies the configuration parameters. func (conf *CapacitySchedulingArgs) Validate() Error ... }

line 55: // An example resource set might includes "cpu" (millicores) and "memory" (bytes)
includes -> include

line 55: // An example resource set might includes "cpu" (millicores) and "memory" (bytes)

thanks. I address it together in this pr.

In general, we can set the default parameters default.go for all plugins: CoScheduling, NodeResouresAllocatable, CapacityScheduling.

Done

@yuanchen8911

k8s-ci-robot · 2020-09-27T07:20:14Z

@denkensk: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

denkensk · 2020-09-28T06:17:33Z

@Huang-Wei @yuanchen8911
Please review it again.
Thanks

hack/update-codegen.sh

Huang-Wei · 2020-09-28T19:10:10Z

hack/update-codegen.sh

-  podgroup:v1alpha1 \
-  --go-header-file "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.generatego.txt
+  "scheduling:v1alpha1" \
+  --go-header-file "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.generatego.txt


Keep the ending character.

pkg/apis/scheduling/register.go

denkensk · 2020-09-29T03:01:49Z

/cc @Huang-Wei
Updated Please review it again.

hack/update-codegen.sh

Huang-Wei · 2020-09-29T05:44:48Z

pkg/apis/config/types.go

+	metav1.TypeMeta
+
+	// KubeConfigPath is the path of kubeconfig.
+	KubeConfigPath *string


Let's make it (internal version) string.

Huang-Wei · 2020-09-29T05:48:37Z

pkg/controller/podgroup.go

-	pgclientset "sigs.k8s.io/scheduler-plugins/pkg/generated/clientset/versioned"
-	pginformer "sigs.k8s.io/scheduler-plugins/pkg/generated/informers/externalversions/podgroup/v1alpha1"
-	pglister "sigs.k8s.io/scheduler-plugins/pkg/generated/listers/podgroup/v1alpha1"
+	schedulingv1alpha1 "sigs.k8s.io/scheduler-plugins/pkg/apis/scheduling/v1alpha1"


nit: the aliases can be shortened to "schedXYZ" (save us 5 characters :))

denkensk · 2020-09-29T06:05:13Z

@Huang-Wei
Please review it again.
Thanks~

Huang-Wei · 2020-09-29T06:33:57Z

Thanks!

/lgtm
/approve

k8s-ci-robot · 2020-09-29T06:34:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: denkensk, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

doc: resync.md: Document release branch upstream resync strategy

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2020

k8s-ci-robot requested a review from ahg-g September 7, 2020 08:52

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 7, 2020

denkensk force-pushed the capacity-scheduling branch from 7a3dfe3 to 099ba2d Compare September 8, 2020 03:15

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2020

denkensk force-pushed the capacity-scheduling branch 2 times, most recently from df1762a to ed186dc Compare September 8, 2020 03:36

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2020

xq2005 reviewed Sep 9, 2020

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2020

denkensk force-pushed the capacity-scheduling branch from b9b7a32 to cec6343 Compare September 22, 2020 13:04

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2020

denkensk changed the title ~~[WIP] Capacity Scheduling Base on Framework~~ Capacity Scheduling Base on Framework Sep 22, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2020

denkensk force-pushed the capacity-scheduling branch 3 times, most recently from dc7d63d to 418b521 Compare September 24, 2020 12:36

k8s-ci-robot requested review from Huang-Wei and yuanchen8911 September 24, 2020 12:37

denkensk force-pushed the capacity-scheduling branch from 418b521 to 4a28ec8 Compare September 25, 2020 03:23

denkensk changed the title ~~Capacity Scheduling Base on Framework~~ ElasticQuota of Capacity Scheduling Api define Sep 25, 2020

Huang-Wei reviewed Sep 25, 2020

View reviewed changes

denkensk closed this Sep 27, 2020

denkensk force-pushed the capacity-scheduling branch from 828dda5 to 88c2dea Compare September 27, 2020 07:18

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2020

k8s-ci-robot reopened this Sep 27, 2020

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2020

Huang-Wei reviewed Sep 28, 2020

View reviewed changes

denkensk force-pushed the capacity-scheduling branch from d1914c9 to 246ea08 Compare September 29, 2020 02:58

k8s-ci-robot requested a review from Huang-Wei September 29, 2020 03:01

denkensk force-pushed the capacity-scheduling branch 2 times, most recently from 09a84c7 to fd0cc56 Compare September 29, 2020 05:42

Huang-Wei reviewed Sep 29, 2020

View reviewed changes

hack/update-codegen.sh Outdated Show resolved Hide resolved

Huang-Wei reviewed Sep 29, 2020

View reviewed changes

denkensk force-pushed the capacity-scheduling branch from fd0cc56 to 457a643 Compare September 29, 2020 05:45

Huang-Wei reviewed Sep 29, 2020

View reviewed changes

denkensk force-pushed the capacity-scheduling branch from 457a643 to 1e13f94 Compare September 29, 2020 06:01

capacity scheduling on framework api define

312c38d

denkensk force-pushed the capacity-scheduling branch from 1e13f94 to 312c38d Compare September 29, 2020 06:13

k8s-ci-robot assigned Huang-Wei Sep 29, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020

k8s-ci-robot merged commit fac4fef into kubernetes-sigs:master Sep 29, 2020

swatisehgal pushed a commit to swatisehgal/scheduler-plugins that referenced this pull request Oct 11, 2022

Merge pull request kubernetes-sigs#50 from swatisehgal/resync-update

08844e2

doc: resync.md: Document release branch upstream resync strategy

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ElasticQuota of Capacity Scheduling Api define #50

ElasticQuota of Capacity Scheduling Api define #50

denkensk commented Sep 7, 2020 •

edited

Loading

xq2005 Sep 9, 2020

denkensk Sep 23, 2020

denkensk commented Sep 24, 2020

denkensk commented Sep 24, 2020

k8s-ci-robot commented Sep 24, 2020

Huang-Wei commented Sep 24, 2020

denkensk commented Sep 25, 2020

Huang-Wei left a comment

Huang-Wei Sep 25, 2020

yuanchen8911 Sep 27, 2020

denkensk Sep 27, 2020

Huang-Wei Sep 28, 2020

Huang-Wei Sep 25, 2020

Huang-Wei Sep 25, 2020

yuanchen8911 Sep 27, 2020 •

edited

Loading

yuanchen8911 Sep 27, 2020

denkensk Sep 27, 2020

k8s-ci-robot commented Sep 27, 2020

denkensk commented Sep 28, 2020

Huang-Wei Sep 28, 2020

denkensk commented Sep 29, 2020

Huang-Wei Sep 29, 2020

denkensk Sep 29, 2020

Huang-Wei Sep 29, 2020

denkensk Sep 29, 2020

denkensk commented Sep 29, 2020

Huang-Wei commented Sep 29, 2020

k8s-ci-robot commented Sep 29, 2020

		@@ -0,0 +1,4 @@
		// +k8s:deepcopy-gen=package
		// +groupName=capacityscheduling.sigs.k8s.io

	// +groupName=capacityscheduling.sigs.k8s.io
	// +groupName=scheduling.sigs.k8s.io

ElasticQuota of Capacity Scheduling Api define #50

ElasticQuota of Capacity Scheduling Api define #50

Conversation

denkensk commented Sep 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denkensk commented Sep 24, 2020

denkensk commented Sep 24, 2020

k8s-ci-robot commented Sep 24, 2020

Huang-Wei commented Sep 24, 2020

denkensk commented Sep 25, 2020

Huang-Wei left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuanchen8911 Sep 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 27, 2020

denkensk commented Sep 28, 2020

Choose a reason for hiding this comment

denkensk commented Sep 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denkensk commented Sep 29, 2020

Huang-Wei commented Sep 29, 2020

k8s-ci-robot commented Sep 29, 2020

denkensk commented Sep 7, 2020 •

edited

Loading

yuanchen8911 Sep 27, 2020 •

edited

Loading