Delete Useless options in controller #569

nayihz · 2023-03-31T10:23:23Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #567

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Delete kubeConfig/incluster/masterUrl options in controller. 
Implentment --worker option.

k8s-ci-robot · 2023-03-31T10:23:33Z

Hi @czybjtu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zwpaper · 2023-04-01T04:42:59Z

hi @czybjtu, thanks for the PR, but maybe we should implement those options instead of deleting them

WDYT @Huang-Wei ?

Huang-Wei · 2023-04-03T05:17:02Z

cmd/controller/app/server.go

-	}
-	schedInformerFactory.Start(stopCh)
-	coreInformerFactory.Start(stopCh)
-	if !s.EnableLeaderElection {


this seems to be totally disabling leader election?

No. No need to implement this manually, the ctrl runtime can handle this instead. We have enabled leader election when create ctrl.NewManager

scheduler-plugins/cmd/controller/app/server.go

Lines 93 to 100 in aeb7ff2

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{

Scheme: scheme,

MetricsBindAddress: s.MetricsAddr,

Port: 9443,

HealthProbeBindAddress: s.ProbeAddr,

LeaderElection: s.EnableLeaderElection,

LeaderElectionID: "sched-plugins-controllers",

LeaderElectionNamespace: "kube-system",

Huang-Wei · 2023-04-03T05:20:01Z

hi @czybjtu, thanks for the PR, but maybe we should implement those options instead of deleting them

Yes, we need to bring the functionality back, which is part of the migration; otherwise, it's a breaking change as params like workers, leader elections are not supported.

@czybjtu are you going to remove and add the param/function back, via 2 PRs? If so, I'm leaning towards merging into one PR, so reviewers only need to review function changes while keep parameters unchanged (or with minimum changes).

nayihz · 2023-04-03T06:11:07Z

AFAIK, after we migrate controllers to controller-runtime, there is no need to implement kubeConfig/incluster/masterUrl manually. The controller-runtime can handle this instead.
The --wokers option was never be implemented before, So I delete this option in this pr. Maybe it's better to implement it. I'll take a look later.

zwpaper · 2023-04-04T04:09:15Z

hi @czybjtu, sorry for the late reply again, I was kinda busy recently.

my concern is that:

ctrl-runtime automatically added a kubeconfig command line flag to the controller, it may be worth a comment in the Option struct.
the kubeconfig cmd flag was changed from kubeConfig, we should add this breaking change in the release note @Huang-Wei
it seems that ctrl-runtime did not handle the masterAddr flag, and it also seems can be replaced by the kubeconfig flag, we may also drop it and notice it in the release note?
the inCluster flag seems to be reasonable to drop, as it can be detected by whether kubeconfig is specified.

ps, I only glanced at the PR, will try to find some free cycles to check it deeply.
thanks so much for raising this PR.

Huang-Wei · 2023-04-05T19:11:19Z

/ok-to-test

I'm not concerned with the features that didn't exist before, we can keep the behavior as-is as long as we can confirm some parameters didn't work (like masters).

For kubeconfig -> kubeConfig and changes alike, I'm less concerned as well. Let's just stick to ctrl-runtime's naming conversion and write a release note about that.

nayihz · 2023-04-06T01:34:46Z

/test pull-scheduler-plugins-integration-test-master

Huang-Wei · 2023-04-06T21:49:18Z

pkg/controllers/elasticquota_controller.go

@@ -173,5 +175,6 @@ func (r *ElasticQuotaReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		Watches(&source.Kind{Type: &v1.Pod{}}, &handler.EnqueueRequestForObject{}).
 		For(&schedv1alpha1.ElasticQuota{}).
+		WithOptions(controller.Options{MaxConcurrentReconciles: r.Workers}).


thanks for adding this.

Huang-Wei · 2023-04-06T21:51:14Z

/approve

Leaving /lgtm to @zwpaper .

k8s-ci-robot · 2023-04-06T21:51:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czybjtu, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zwpaper · 2023-04-08T08:05:47Z

/lgtm

thanks for the contribution @czybjtu!

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 31, 2023

k8s-ci-robot requested review from Tal-or and zwpaper March 31, 2023 10:23

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 31, 2023

Huang-Wei reviewed Apr 3, 2023

View reviewed changes

Delete Useless options in controller

0383bfd

nayihz force-pushed the feat_del_options branch from 526dfe0 to 0383bfd Compare April 4, 2023 02:51

nayihz requested a review from Huang-Wei April 4, 2023 03:01

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2023

Huang-Wei reviewed Apr 6, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023

k8s-ci-robot assigned zwpaper Apr 8, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2023

k8s-ci-robot merged commit e70dedf into kubernetes-sigs:master Apr 8, 2023

zwpaper mentioned this pull request Apr 8, 2023

migrate controllers and clients to leverage controller-runtime #485

Closed

17 tasks

nayihz deleted the feat_del_options branch April 10, 2023 01:06

nayihz mentioned this pull request Apr 10, 2023

REQUEST: New membership for czybjtu kubernetes/org#4154

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete Useless options in controller #569

Delete Useless options in controller #569

nayihz commented Mar 31, 2023 •

edited

k8s-ci-robot commented Mar 31, 2023

zwpaper commented Apr 1, 2023

Huang-Wei Apr 3, 2023

nayihz Apr 3, 2023 •

edited

nayihz Apr 3, 2023

Huang-Wei commented Apr 3, 2023

nayihz commented Apr 3, 2023

zwpaper commented Apr 4, 2023 •

edited

Huang-Wei commented Apr 5, 2023

nayihz commented Apr 6, 2023

Huang-Wei Apr 6, 2023

Huang-Wei commented Apr 6, 2023

k8s-ci-robot commented Apr 6, 2023

zwpaper commented Apr 8, 2023

	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
	Scheme: scheme,
	MetricsBindAddress: s.MetricsAddr,
	Port: 9443,
	HealthProbeBindAddress: s.ProbeAddr,
	LeaderElection: s.EnableLeaderElection,
	LeaderElectionID: "sched-plugins-controllers",
	LeaderElectionNamespace: "kube-system",

Delete Useless options in controller #569

Delete Useless options in controller #569

Conversation

nayihz commented Mar 31, 2023 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented Mar 31, 2023

zwpaper commented Apr 1, 2023

Huang-Wei Apr 3, 2023

Choose a reason for hiding this comment

nayihz Apr 3, 2023 • edited

Choose a reason for hiding this comment

nayihz Apr 3, 2023

Choose a reason for hiding this comment

Huang-Wei commented Apr 3, 2023

nayihz commented Apr 3, 2023

zwpaper commented Apr 4, 2023 • edited

Huang-Wei commented Apr 5, 2023

nayihz commented Apr 6, 2023

Huang-Wei Apr 6, 2023

Choose a reason for hiding this comment

Huang-Wei commented Apr 6, 2023

k8s-ci-robot commented Apr 6, 2023

zwpaper commented Apr 8, 2023

nayihz commented Mar 31, 2023 •

edited

nayihz Apr 3, 2023 •

edited

zwpaper commented Apr 4, 2023 •

edited