feat: Support disabling Helm chart CRD hooks

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
kubernetes-sigs · Nov 15, 2022 · 34cb436 · 34cb436
1 parent 41dc61b
commit 34cb436
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/manifest_staging/charts/secrets-store-csi-driver/README.md b/manifest_staging/charts/secrets-store-csi-driver/README.md
@@ -34,6 +34,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
 | `linux.image.repository`                | Linux image repository                                                                                                                                                         | `k8s.gcr.io/csi-secrets-store/driver`                   |
 | `linux.image.pullPolicy`                | Linux image pull policy                                                                                                                                                        | `IfNotPresent`                                          |
 | `linux.image.tag`                       | Linux image tag                                                                                                                                                                | `v1.2.4`                                                |
+| `linux.crds.enabled`                    | If the CRDs should be managed by the chart                                                                                                                                     | `true`                                                  |
 | `linux.crds.image.repository`           | Linux crds image repository                                                                                                                                                    | `k8s.gcr.io/csi-secrets-store/driver-crds`              |
 | `linux.crds.image.pullPolicy`           | Linux crds image pull policy                                                                                                                                                   | `IfNotPresent`                                          |
 | `linux.crds.image.tag`                  | Linux crds image tag                                                                                                                                                           | `v1.2.4`                                                |

diff --git a/manifest_staging/charts/secrets-store-csi-driver/templates/crds-upgrade-hook.yaml b/manifest_staging/charts/secrets-store-csi-driver/templates/crds-upgrade-hook.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.linux.crds.enabled -}}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
@@ -123,3 +124,4 @@ spec:
       tolerations:
 {{ toYaml . | indent 8 }}
 {{- end }}
+{{- end }}
diff --git a/manifest_staging/charts/secrets-store-csi-driver/templates/keep-crds-upgrade-hook.yaml b/manifest_staging/charts/secrets-store-csi-driver/templates/keep-crds-upgrade-hook.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.linux.crds.enabled -}}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
@@ -126,3 +127,4 @@ spec:
       tolerations:
 {{ toYaml . | indent 8 }}
 {{- end }}
+{{- end }}
diff --git a/manifest_staging/charts/secrets-store-csi-driver/values.yaml b/manifest_staging/charts/secrets-store-csi-driver/values.yaml
@@ -6,6 +6,7 @@ linux:
     pullPolicy: IfNotPresent
 
   crds:
+    enabled: true
     image:
       repository: k8s.gcr.io/csi-secrets-store/driver-crds
       tag: v1.2.4