Skip to content

Commit

Permalink
test: improve nodeserver testing
Browse files Browse the repository at this point in the history
Cleanup some variable names in tests and split success/failure into
separate test cases when it seems like the expectation logic should
be different
(https://github.com/golang/go/wiki/TestComments#table-driven-tests-vs-multiple-test-functions).

I also updated this to use a mock provider grpc server like we use
in the rotation reconciler.

This improves the package test coverage from 55.8% -> 56.9%.
  • Loading branch information
tam7t committed May 20, 2023
1 parent c2739b3 commit 4a54858
Showing 1 changed file with 226 additions and 239 deletions.

0 comments on commit 4a54858

Please sign in to comment.