Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update manifest and helm charts for v1.2.4 #1043

Merged
merged 1 commit into from Sep 7, 2022

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Sep 7, 2022

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2022
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version needs to be updated

RELEASE_VERSION := v1.2.3
IMAGE_VERSION ?= v1.2.3.0
and
IMAGE_VERSION?=v1.2.3.0

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Sep 7, 2022

The version needs to be updated

RELEASE_VERSION := v1.2.3
IMAGE_VERSION ?= v1.2.3.0

and

IMAGE_VERSION?=v1.2.3.0

Done.

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
(for cherrypick to be merged to release branch)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@nilekhc
Copy link
Contributor Author

nilekhc commented Sep 7, 2022

/test pull-secrets-store-csi-driver-e2e-aws

k8s-ci-robot added a commit that referenced this pull request Sep 7, 2022
…upstream-release-1.2

Automated cherry pick of #1043: release: update manifest and helm charts for v1.2.4
@aramase
Copy link
Member

aramase commented Sep 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5628d7e into kubernetes-sigs:main Sep 7, 2022
@nilekhc nilekhc deleted the release-v1.2.4 branch September 7, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants