Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handles sha string in tag #1565

Merged

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Jun 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1539

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2024
@nilekhc nilekhc requested a review from aramase June 27, 2024 23:19
@k8s-ci-robot k8s-ci-robot requested a review from ritazh June 27, 2024 23:19
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2024
@nilekhc nilekhc force-pushed the nilekh/c/update-semvar-check branch from 4256885 to bbba7f8 Compare June 28, 2024 16:40
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this change simple, I would be fine with just dropping all the semver checks altogether. The checks are for really old versions and no longer relevant for the project because they're unsupported releases/chart versions.

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc force-pushed the nilekh/c/update-semvar-check branch from bbba7f8 to 18619d1 Compare June 28, 2024 17:56
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2024
@nilekhc nilekhc requested a review from aramase June 28, 2024 17:56
@nilekhc
Copy link
Contributor Author

nilekhc commented Jun 28, 2024

To keep this change simple, I would be fine with just dropping all the semver checks altogether. The checks are for really old versions and no longer relevant for the project because they're unsupported releases/chart versions.

I have removed it. PTAL.

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit f49f22f into kubernetes-sigs:main Jun 28, 2024
21 checks passed
@nilekhc nilekhc deleted the nilekh/c/update-semvar-check branch June 29, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm install/update fails when sha is used instead of semvar in image tag
3 participants