Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests for windows #181

Merged
merged 4 commits into from Apr 7, 2020
Merged

update tests for windows #181

merged 4 commits into from Apr 7, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Apr 6, 2020 •
edited

  • Updates makefile to add rule for windows-e2e
  • Adds helm chart for windows

fixes #179

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2020
@aramase
Copy link
Member Author

aramase commented Apr 6, 2020

/hold

(using prow to test the PR as having trouble with dev machine). Will remove hold and assign when ready for review

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@k8s-ci-robot k8s-ci-robot requested a review from ritazh April 6, 2020 19:59
@aramase aramase added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2020
aramase
aramase commented Apr 7, 2020
View reviewed changes
charts/secrets-store-csi-driver/templates/csidriver.yaml
@@ -5,7 +5,8 @@ metadata:
spec:
podInfoOnMount: true
attachRequired: false
{{- if and ( ge (.Capabilities.KubeVersion.Major | int) 1 ) ( ge (.Capabilities.KubeVersion.Minor | int) 16 ) }}
volumeLifecycleModes: # Added in Kubernetes 1.16 with default mode of Persistent. Secrets store csi driver needs Ephermeral to be set.
{{- if semverCompare ">=1.16-0" .Capabilities.KubeVersion.GitVersion }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using int compare does not work for pre-release versions (alpha/beta). So switched this to use semverCompare instead.

@aramase
Copy link
Member Author

aramase commented Apr 7, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2020
@aramase
Copy link
Member Author

aramase commented Apr 7, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member Author

aramase commented Apr 7, 2020

/test pull-secrets-store-csi-driver-e2e-windows

ritazh
ritazh reviewed Apr 7, 2020
View reviewed changes
Makefile
.PHONY: install-driver
install-driver:
ifdef TEST_WINDOWS
helm install csi-secrets-store charts/secrets-store-csi-driver --namespace default --wait --timeout=15m -v=5 --debug \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the same helm install cmd but set diff variables in the if/else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables for linux and windows are different which is why the helm install cmd is different in if/else

@aramase
Copy link
Member Author

aramase commented Apr 7, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member Author

aramase commented Apr 7, 2020

@ritazh PTAL when you get a chance! Updated the charts to support hybrid scenarios and also added liveness probe sidecar for windows.

@ritazh
Copy link
Member

ritazh commented Apr 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@aramase
Copy link
Member Author

aramase commented Apr 7, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 803e030 into kubernetes-sigs:master Apr 7, 2020
@aramase aramase deleted the windows-e2e branch April 7, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh left review comments

Assignees

@ritazh ritazh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e test suite
3 participants
@aramase @k8s-ci-robot @ritazh