Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to sync k8s secret #186

Merged
merged 8 commits into from Apr 28, 2020

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Apr 20, 2020

Fixes #167

Release note:

Users now have the ability to sync K8s secrets by adding secretObjects to the SecretProviderClass spec to create k8s secrets from the mounted file content
  • unit test
  • e2e test

Follow up items:

Updated secretsproviderclass spec:

spec:
  parameters:
    objects: |
      array:
        - |
          objectPath: "/foo"
          objectName: "bar"
          objectVersion: ""
        - |
          objectPath: "/foo1"
          objectName: "bar"
          objectVersion: ""
    roleName: example-role
    vaultAddress: http://10.0.219.186:8200
    vaultSkipTLSVerify: "true"
  provider: vault
  secretObjects:
  - data:
    - key: pwd
      objectName: foo
    - key: username
      objectName: foo1
    secretName: foosecret
    type: Opaque
status:
  byPod:
  - id: 07b8b844-797d-4fa5-9638-e93c4e5f467c
    namespace: default
  - id: 101c3595-1863-4571-8b40-d32d51691335
    namespace: default

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
charts/secrets-store-csi-driver/templates/role.yaml Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/utils.go Show resolved Hide resolved
pkg/secrets-store/utils.go Outdated Show resolved Hide resolved
pkg/secrets-store/utils.go Show resolved Hide resolved
pkg/secrets-store/utils.go Outdated Show resolved Hide resolved
pkg/secrets-store/utils.go Outdated Show resolved Hide resolved
pkg/secrets-store/utils.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver.go Outdated Show resolved Hide resolved
pkg/secrets-store/utils.go Show resolved Hide resolved
pkg/secrets-store/utils.go Show resolved Hide resolved
pkg/secrets-store/utils.go Show resolved Hide resolved
pkg/secrets-store/utils.go Outdated Show resolved Hide resolved
pkg/secrets-store/utils_test.go Show resolved Hide resolved
@aramase
Copy link
Member

aramase commented Apr 28, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@ritazh
Copy link
Member Author

ritazh commented Apr 28, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@ritazh ritazh force-pushed the feat-synck8s branch 2 times, most recently from bc615c7 to a8fcb1e Compare April 28, 2020 18:38
@aramase
Copy link
Member

aramase commented Apr 28, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member

aramase commented Apr 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2020
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Add option to sync with Kubernetes secrets
3 participants