Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: make all images configurable #260

Merged
merged 1 commit into from
Aug 6, 2020
Merged

helm: make all images configurable #260

merged 1 commit into from
Aug 6, 2020

Conversation

Annegies
Copy link
Contributor

@Annegies Annegies commented Jul 28, 2020 •
edited by aramase

What this PR does / why we need it:
This PR allows to configure all the image repositories if needed. For our container platfom only containers from private registries are allowed.

fixes #255

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Annegies!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Annegies. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2020
@Annegies
Copy link
Contributor Author

/assign @aramase

aramase
aramase reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Added few comments. Could you also add the new fields to Configuration table in the readme?

charts/secrets-store-csi-driver/Chart.yaml Outdated Show resolved Hide resolved
charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml Outdated Show resolved Hide resolved
@aramase
Copy link
Member

aramase commented Jul 28, 2020

/retitle helm: make all images configurable

@k8s-ci-robot k8s-ci-robot changed the title [Chart] Make all images configurable helm: make all images configurable Jul 28, 2020
@aramase aramase added this to the v0.0.13 milestone Jul 28, 2020
@Annegies
Copy link
Contributor Author

Thanks for the review, resolved your comments

@ritazh
Copy link
Member

ritazh commented Jul 29, 2020

This PR might make sense to be part of the manifest_staging/charts directory once it's available from #258 as we want to ensure each chart/yaml update is part of a tagged release.

@Annegies
Copy link
Contributor Author

I don't mind, we'll use our own chart until then!

@ritazh ritazh mentioned this pull request Jul 30, 2020
Closed
@aramase
Copy link
Member

aramase commented Jul 31, 2020

@Annegies #258 has been merged. Can you update the PR to make all the changes for helm chart in manifest_staging?

@Annegies
Copy link
Contributor Author

Annegies commented Aug 3, 2020 •
edited

Applied the changes to the chart in manifest_staging

aramase
aramase reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Annegies Added few small nits. PTAL when you get a chance. Could you also squash to a single commit once the changes are done?

manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
manifest_staging/charts/secrets-store-csi-driver/values.yaml Show resolved Hide resolved
@aramase aramase mentioned this pull request Aug 4, 2020
Closed
@Annegies
Copy link
Contributor Author

Annegies commented Aug 4, 2020

Resolved your comments and squashed the commit

@aramase
Copy link
Member

aramase commented Aug 4, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2020
aramase
aramase reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Annegies Just one small nit and then we are good to merge

manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
manifest_staging/charts/secrets-store-csi-driver/README.md Outdated Show resolved Hide resolved
@Annegies
parent 97a187e
1b85d6b 
author Annegies van 't Zand <ace.vtzand@gmail.com> 1595940905 +0200
committer Annegies van 't Zand <ace.vtzand@gmail.com> 1596521061 +0200

Make all images configurable in order to use private registries

fix references

Rename livenessProbeImage and add to configuration table

Apply changes in the manifest_staging

Add fields to configuration

Make private registries possible

Make all images configurable in order to use private registries

rename register

Make all images configurable in order to use private registries
@Annegies
Copy link
Contributor Author

Annegies commented Aug 5, 2020

Again, resolved

@aramase
Copy link
Member

aramase commented Aug 5, 2020

/test pull-secrets-store-csi-driver-e2e-windows

1 similar comment
@aramase
Copy link
Member

aramase commented Aug 5, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member

aramase commented Aug 5, 2020

The windows test job template needs to be updated. Will re-run the windows test once that update is complete.

@aramase
Copy link
Member

aramase commented Aug 5, 2020

/test pull-secrets-store-csi-driver-e2e-windows

aramase
aramase reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2020
@ritazh
Copy link
Member

ritazh commented Aug 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Annegies, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@ritazh
Copy link
Member

ritazh commented Aug 6, 2020

/test pull-secrets-store-csi-driver-e2e-azure

@k8s-ci-robot k8s-ci-robot merged commit 1362606 into kubernetes-sigs:master Aug 6, 2020
This was referenced Aug 13, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.0.13
Development

Successfully merging this pull request may close these issues.

Provide override for node-driver-registrar and liveliness-probe containers in helm chart
4 participants
@Annegies @k8s-ci-robot @aramase @ritazh