Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes: pass csi.storage.k8s.io/serviceAccount.name #267

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Jul 30, 2020

What this PR does / why we need it:

Passing through the csi.storage.k8s.io/serviceAccount.name parameter will allow plugins who need to obtain K8S SA tokens to perform
workload identity to not need to perform additional get pod K8S API calls.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

See: GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp#29

Special notes for your reviewer:

Passing through the csi.storage.k8s.io/serviceAccount.name parameter
will allow plugins who need to obtain K8S SA tokens to perform
workload identity to not need to perform additional get pod K8S API
calls.

See: GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp#29
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tam7t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2020
@aramase
Copy link
Member

aramase commented Jul 30, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 30, 2020
@aramase aramase added this to the v0.0.13 milestone Jul 30, 2020
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tam7t Thank you for the PR 🎉 It'll be really nice to have e2e validation for these once we add the provider

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2020
@ritazh
Copy link
Member

ritazh commented Jul 30, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritazh, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@aramase
Copy link
Member

aramase commented Jul 30, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit a4bb7c6 into kubernetes-sigs:master Jul 31, 2020
@tam7t tam7t deleted the tam7t/add-sa-attrib branch August 1, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants