-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attributes: pass csi.storage.k8s.io/serviceAccount.name #267
attributes: pass csi.storage.k8s.io/serviceAccount.name #267
Conversation
Passing through the csi.storage.k8s.io/serviceAccount.name parameter will allow plugins who need to obtain K8S SA tokens to perform workload identity to not need to perform additional get pod K8S API calls. See: GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp#29
Hi @tam7t. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tam7t Thank you for the PR 🎉 It'll be really nice to have e2e validation for these once we add the provider
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ritazh, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
Passing through the csi.storage.k8s.io/serviceAccount.name parameter will allow plugins who need to obtain K8S SA tokens to perform
workload identity to not need to perform additional get pod K8S API calls.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):See: GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp#29
Special notes for your reviewer: