helm: move tolerations block inside OS conditional in helm chart #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduced in a previous PR, the tolerations block should be inside the
{{- if .Values.linux/windows.enabled}}
conditional in the Daemon Set yaml; it is currently outside.This could cause issues if the
enabled
flag of a specific OS is false, but there are tolerations defined for it.Special notes for your reviewer:
Detected while testing with
secrets-store-csi-driver-provider-azure