Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metadata.label to synced secret #273

Merged
merged 1 commit into from
Aug 6, 2020
Merged

feat: add metadata.label to synced secret #273

merged 1 commit into from
Aug 6, 2020

Conversation

helayoty
Copy link
Contributor

@helayoty helayoty commented Aug 4, 2020

What this PR does / why we need it:

There was an ask to support label in synced secrets

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #217

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @helayoty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2020
aramase
aramase reviewed Aug 4, 2020
View reviewed changes
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
controllers/secretproviderclasspodstatus_controller_test.go Outdated Show resolved Hide resolved
controllers/secretproviderclasspodstatus_controller_test.go Outdated Show resolved Hide resolved
deploy/secrets-store.csi.x-k8s.io_secretproviderclasses.yaml Outdated Show resolved Hide resolved
test/bats/azure.bats Outdated Show resolved Hide resolved
test/bats/azure.bats Outdated Show resolved Hide resolved
@aramase aramase added this to the v0.0.13 milestone Aug 4, 2020
@helayoty helayoty changed the title feat: Add metadata.label to synced secret feat: add metadata.label to synced secret Aug 4, 2020
@helayoty helayoty requested a review from aramase August 4, 2020 22:00
@helayoty helayoty marked this pull request as ready for review August 4, 2020 22:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2020
aramase
aramase reviewed Aug 4, 2020
View reviewed changes
test/bats/vault.bats Outdated Show resolved Hide resolved
aramase
aramase reviewed Aug 4, 2020
View reviewed changes
test/bats/azure.bats Outdated Show resolved Hide resolved
aramase
aramase reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helayoty Thank you for the PR. Added few comments. PTAL! Also, could you squash to a single commit?

@helayoty helayoty requested a review from aramase August 5, 2020 01:37
@aramase
Copy link
Member

aramase commented Aug 5, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2020
@aramase
Copy link
Member

aramase commented Aug 5, 2020

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member

aramase commented Aug 5, 2020

The windows test job template needs to be updated. Will re-run the windows test once that update is complete.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 5, 2020
@aramase
Copy link
Member

aramase commented Aug 5, 2020

/retest
/test pull-secrets-store-csi-driver-e2e-windows

aramase
aramase reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2020
@ritazh
Copy link
Member

ritazh commented Aug 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helayoty, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit ac02684 into kubernetes-sigs:master Aug 6, 2020
@cjyar cjyar mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.0.13
Development

Successfully merging this pull request may close these issues.

Enable add metadata.label to synced secret
4 participants
@helayoty @k8s-ci-robot @aramase @ritazh