New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priorityClassName to daemonsets. #337
Add priorityClassName to daemonsets. #337
Conversation
Welcome @derek-burdick! |
Hi @derek-burdick. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2ca066e
to
3bb0cd2
Compare
CLA signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derek-burdick Thank you for the PR!
Could you make these changes only in manifest_changing/charts dir instead of charts dir? The chart changes are stored in the staging dir and move to charts during the release.
3bb0cd2
to
ed86df7
Compare
@aramase Moved to manifest_staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derek-burdick Could you also add the new values to the configuration table here
/ok-to-test |
4b1ad72
to
abb03b1
Compare
@aramase Should I add the default value ("") to the values.yaml file as well? |
priorityClassName to values.yaml.
abb03b1
to
fab04f2
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derek-burdick, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
This PR adds provides the option to add a priorityClassName to the PODS. In some environments, pods with a higher priority set can preempt this pod and cause issues with the driver. This also allows the scheduler to preempt lower priority pods if this pod needs to be recreated.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: