Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP plugin: integration tests #340

Merged
merged 1 commit into from
Oct 15, 2020
Merged

GCP plugin: integration tests #340

merged 1 commit into from
Oct 15, 2020

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Oct 9, 2020 •
edited

What this PR does / why we need it:

Adds integration tests for the GCP Secret Manager plugin: https://github.com/GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Starting with a single test case.

Changes to test-infra: kubernetes/test-infra#19512

and uploading of a new secret (gcp-secrets-store-cred) to prow

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tam7t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2020
@tam7t tam7t mentioned this pull request Oct 9, 2020
Merged
aramase
aramase reviewed Oct 13, 2020
View reviewed changes
test/bats/gcp.bats Outdated
WAIT_TIME=60
SLEEP_TIME=1
NAMESPACE=default
PROVIDER_YAML=https://raw.githubusercontent.com/GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp/tam7t/v010/deploy/provider-gcp-plugin.yaml
Copy link
Member

@aramase aramase Oct 13, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the url be https://github.com/GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp/blob/main/deploy/provider-gcp-plugin.yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this branch has the correct build referenced in the yaml where the main branch does not have it yet. I will update this PR once I merge GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp#59 and push a new release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated for the main branch.

@aramase
Copy link
Member

aramase commented Oct 13, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2020
aramase
aramase reviewed Oct 13, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@aramase aramase added this to In progress in Roadmap Oct 13, 2020
@tam7t
Copy link
Contributor Author

tam7t commented Oct 13, 2020

/retest

@tam7t tam7t mentioned this pull request Oct 13, 2020
Merged
@aramase
Copy link
Member

aramase commented Oct 13, 2020

@tam7t Could you squash the commits?

aramase
aramase reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@tam7t @aramase
tests: gcp integration tests
31f6f30 
Update Makefile

Correct the format of the gcpSupportedProviders flag

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@tam7t
Copy link
Contributor Author

tam7t commented Oct 14, 2020

/assign @aramase

@tam7t tam7t requested a review from aramase October 14, 2020 16:14
aramase
aramase reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@ritazh
Copy link
Member

ritazh commented Oct 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritazh, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 320afdb into kubernetes-sigs:master Oct 15, 2020
@tam7t tam7t deleted the tam7t/gcp-tests branch October 15, 2020 14:52
@tam7t tam7t mentioned this pull request Oct 15, 2020
Closed
@tam7t tam7t mentioned this pull request Nov 6, 2020
Closed
6 tasks
@tam7t tam7t mentioned this pull request Apr 14, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Roadmap
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tam7t @k8s-ci-robot @aramase @ritazh