Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update demo in the readme #363

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 23, 2020

What this PR does / why we need it:

  • Updates demo in the readme

I've added the svg too to the img folder. Github seems to take a while to render the svg in the readme so using the asciicast player. This also provides the users with an option to pause if required.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #369

Special notes for your reviewer:

svg-term --cast=367389 --out demo.svg --window

Update

Changed to just using gif instead

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2020
@aramase aramase force-pushed the update-demo branch 3 times, most recently from c8b2c0b to 64fc1d6 Compare October 27, 2020 06:01
@ritazh
Copy link
Member

ritazh commented Nov 3, 2020

@aramase
Copy link
Member Author

aramase commented Nov 3, 2020

@aramase seems the gif in the readme needs to be updated again. https://github.com/kubernetes-sigs/secrets-store-csi-driver/tree/64fc1d64de24e2090a27e9bc856cd203bff59793

@ritazh Updated!

@ritazh
Copy link
Member

ritazh commented Nov 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit ae67720 into kubernetes-sigs:master Nov 5, 2020
@aramase aramase deleted the update-demo branch November 5, 2020 16:18
@aramase aramase mentioned this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update demo in README
3 participants