Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update deps and switch to klog #365

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 29, 2020

What this PR does / why we need it:

/kind feature

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #347

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2020
@aramase aramase force-pushed the update-deps branch 2 times, most recently from d311d0f to 9f729fe Compare October 29, 2020 05:00
@aramase
Copy link
Member Author

aramase commented Oct 29, 2020

/test all

@aramase
Copy link
Member Author

aramase commented Oct 29, 2020

/test all

@aramase aramase marked this pull request as ready for review November 2, 2020 19:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2020
@aramase
Copy link
Member Author

aramase commented Nov 2, 2020

/cc @tam7t

@k8s-ci-robot
Copy link
Contributor

@aramase: GitHub didn't allow me to request PR reviews from the following users: tam7t.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tam7t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aramase
Copy link
Member Author

aramase commented Nov 2, 2020

@ritazh @tam7t @tomhjp PTAL at this PR when you get a chance. Switches to using klog with structured logging.

Copy link
Contributor

@tam7t tam7t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the changes!

controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2020
@aramase aramase requested a review from ritazh November 3, 2020 18:45
@aramase
Copy link
Member Author

aramase commented Nov 3, 2020

W1103 19:54:33.628501       1 main.go:75] --debug flag has been DEPRECATED and will be removed in future releases. Use -v=<log level> to configure log verbosity.
I1103 19:54:33.628557       1 exporter.go:35] metrics backend: prometheus
I1103 19:54:33.932774       1 main.go:111] starting manager
I1103 19:54:34.125354       1 reconciler.go:122] starting rotation reconciler with poll interval: 10s
I1103 19:54:34.429055       1 secrets-store.go:97] Driver: secrets-store.csi.k8s.io
I1103 19:54:34.429084       1 secrets-store.go:98] Version: klog1103
I1103 19:54:34.429090       1 secrets-store.go:99] Provider Volume Path: /etc/kubernetes/secrets-store-csi-providers
I1103 19:54:34.429095       1 secrets-store.go:100] Minimum provider versions:
I1103 19:54:34.429101       1 secrets-store.go:101] GRPC supported providers: azure
I1103 19:54:34.429125       1 driver.go:82] "Enabling controller service capability" capability="CREATE_DELETE_VOLUME"
I1103 19:54:34.429149       1 driver.go:92] "Enabling volume access mode" mode="SINGLE_NODE_READER_ONLY"
I1103 19:54:34.429157       1 driver.go:92] "Enabling volume access mode" mode="MULTI_NODE_READER_ONLY"
I1103 19:54:34.429326       1 secrets-store.go:65] minimum compatible provider versions not specified with --min-provider-version
I1103 19:54:34.429531       1 server.go:107] Listening for connections on address: //csi/csi.sock
I1103 19:55:42.519632       1 nodeserver.go:303] "Using grpc client" provider="azure" pod="demo-pod"
I1103 19:55:45.172183       1 nodeserver.go:204] "node publish volume complete" targetPath="/var/lib/kubelet/pods/9ed22c28-c855-446a-abd4-27abedb2dc86/volumes/kubernetes.io~csi/secrets-store-inline/mount" pod="default/demo-pod"
I1103 19:55:45.172279       1 secretproviderclasspodstatus_controller.go:184] "reconcile started" spcps="default/demo-pod-default-azure-kv"
I1103 19:55:45.272632       1 secretproviderclasspodstatus_controller.go:223] "no secret objects defined for spc, nothing to reconcile" spc="default/azure-kv" spcps="default/demo-pod-default-azure-kv"
I1103 19:55:55.023670       1 reconciler.go:334] "spc doesn't contain secret objects" spc="default/azure-kv" pod="default/demo-pod" controller="rotation"
I1103 19:56:04.624088       1 reconciler.go:334] "spc doesn't contain secret objects" spc="default/azure-kv" pod="default/demo-pod" controller="rotation"
I1103 19:56:14.412594       1 reconciler.go:334] "spc doesn't contain secret objects" spc="default/azure-kv" pod="default/demo-pod" controller="rotation"
I1103 19:56:24.524138       1 reconciler.go:334] "spc doesn't contain secret objects" spc="default/azure-kv" pod="default/demo-pod" controller="rotation"
I1103 19:56:30.891735       1 secretproviderclasspodstatus_controller.go:184] "reconcile started" spcps="default/demo-pod-default-azure-kv"
I1103 19:56:30.891786       1 secretproviderclasspodstatus_controller.go:189] "reconcile complete" spcps="default/demo-pod-default-azure-kv"
I1103 19:56:32.698088       1 nodeserver.go:254] "node unpublish volume complete" targetPath="/var/lib/kubelet/pods/9ed22c28-c855-446a-abd4-27abedb2dc86/volumes/kubernetes.io~csi/secrets-store-inline/mount" podUID="9ed22c28-c855-446a-abd4-27abedb2dc86"
I1103 19:57:07.128802       1 nodeserver.go:303] "Using grpc client" provider="azure" pod="nginx-68c67c5b5c-2x6dz"
I1103 19:57:07.828733       1 nodeserver.go:204] "node publish volume complete" targetPath="/var/lib/kubelet/pods/e4385fe3-b8a3-4a64-b22e-5a96d2eaed39/volumes/kubernetes.io~csi/secrets-store-inline/mount" pod="default/nginx-68c67c5b5c-2x6dz"
I1103 19:57:07.828759       1 secretproviderclasspodstatus_controller.go:184] "reconcile started" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"
I1103 19:57:08.031832       1 secretproviderclasspodstatus_controller.go:351] "successfully created Kubernetes secret" secret="default/foosecret"
I1103 19:57:08.031867       1 secretproviderclasspodstatus_controller.go:323] "reconcile complete" spc="default/azure" pod="default/nginx-68c67c5b5c-2x6dz" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"
I1103 19:57:54.621014       1 reconciler.go:305] "updating versions in spc pod status" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure" controller="rotation"
I1103 19:57:54.627755       1 secretproviderclasspodstatus_controller.go:184] "reconcile started" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"
I1103 19:57:54.627985       1 secretproviderclasspodstatus_controller.go:323] "reconcile complete" spc="default/azure" pod="default/nginx-68c67c5b5c-2x6dz" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"
I1103 19:58:50.798594       1 nodeserver.go:254] "node unpublish volume complete" targetPath="/var/lib/kubelet/pods/e4385fe3-b8a3-4a64-b22e-5a96d2eaed39/volumes/kubernetes.io~csi/secrets-store-inline/mount" podUID="e4385fe3-b8a3-4a64-b22e-5a96d2eaed39"
E1103 19:58:53.933237       1 secretproviderclasspodstatus_controller.go:98] "failed to patch secret owner ref" err="failed to get spc azure, err: SecretProviderClass.secrets-store.csi.x-k8s.io \"azure\" not found"
E1103 19:58:54.125617       1 reconciler.go:492] "failed to reconcile spc for pod" err="failed to get secret provider class default/azure, err: secretproviderclasses.secrets-store.csi.x-k8s.io \"default/azure\" not found" spc="azure" pod="nginx-68c67c5b5c-2x6dz" controller="rotation"
E1103 19:58:58.933080       1 secretproviderclasspodstatus_controller.go:98] "failed to patch secret owner ref" err="failed to get spc azure, err: SecretProviderClass.secrets-store.csi.x-k8s.io \"azure\" not found"
I1103 19:59:00.392380       1 secretproviderclasspodstatus_controller.go:184] "reconcile started" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"
I1103 19:59:00.392437       1 secretproviderclasspodstatus_controller.go:189] "reconcile complete" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"
I1103 19:59:04.282272       1 reconciler.go:519] "retry budget exceeded, dropping from queue" spcps="default/nginx-68c67c5b5c-2x6dz-default-azure"

@ritazh
Copy link
Member

ritazh commented Nov 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 88509ac into kubernetes-sigs:master Nov 5, 2020
@aramase aramase deleted the update-deps branch November 5, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to klog
4 participants