Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dial: grpc naming is not compatible with windows unix socket #490

Merged
merged 1 commit into from Mar 25, 2021

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Mar 24, 2021

What this PR does / why we need it:

Windows grpc connections are currently broken:

E0324 17:53:17.547284    6228 utils.go:79] GRPC error: failed to mount secrets store objects for pod default/nginx-secrets-store-inline-crd, err: rpc error: code = DeadlineExceeded desc = latest balancer error: connection error: desc = "transport: Error while dialing dial tcp: address unix://C:\\k\\secrets-store-csi-providers/azure.sock: too many colons in address"

Believe this was caused by #462 where grpc.Dial was replaced with grpc.DialContext.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 24, 2021
@aramase
Copy link
Member

aramase commented Mar 24, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2021
@aramase
Copy link
Member

aramase commented Mar 24, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member

aramase commented Mar 24, 2021

/test pull-secrets-store-csi-driver-e2e-windows

rerunning because there were few flakes in the last run

@aramase
Copy link
Member

aramase commented Mar 24, 2021

Looking at the kubelet logs, the failure seems to be windows related:

E0324 20:00:34.516993    4368 cni.go:364] Error adding default_nginx-secrets-store-inline-crd/7f0098aba9421d5a4fc9984d50db88905f1ee173acb296179156984faa73f423 to network azure-vnet/azure: A virtual machine or container with the specified identifier does not exist.
E0324 20:00:34.516993    4368 cni_windows.go:59] error while adding to cni network: A virtual machine or container with the specified identifier does not exist.
W0324 20:00:34.516993    4368 docker_sandbox.go:400] failed to read pod IP from plugin/docker: networkPlugin cni failed on the status hook for pod "nginx-secrets-store-inline-crd_default": A virtual machine or container with the specified identifier does not exist.

I see in the logs that the csi driver is mounting correctly:

I0324 20:32:00.551056    5056 operation_generator.go:657] MountVolume.SetUp succeeded for volume "secrets-store-inline" (UniqueName: "kubernetes.io/csi/00f9264d-5a37-4e02-9ca5-abc01e10215a-secrets-store-inline") pod "nginx-secrets-store-inline-crd" (UID: "00f9264d-5a37-4e02-9ca5-abc01e10215a") 

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2021
@aramase aramase force-pushed the tam7t/windows-unix branch 2 times, most recently from 769fdc1 to 3c70752 Compare March 24, 2021 22:11
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2021
@aramase
Copy link
Member

aramase commented Mar 25, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@aramase
Copy link
Member

aramase commented Mar 25, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2021
@aramase
Copy link
Member

aramase commented Mar 25, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@aramase aramase added this to the v0.0.21 milestone Mar 25, 2021
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 16834d4 into kubernetes-sigs:master Mar 25, 2021
@tam7t tam7t deleted the tam7t/windows-unix branch March 25, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants