New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dial: grpc naming is not compatible with windows unix socket #490
Conversation
/test pull-secrets-store-csi-driver-e2e-windows |
750f3c3
to
9807ae9
Compare
/test pull-secrets-store-csi-driver-e2e-windows |
/test pull-secrets-store-csi-driver-e2e-windows rerunning because there were few flakes in the last run |
Looking at the kubelet logs, the failure seems to be windows related: E0324 20:00:34.516993 4368 cni.go:364] Error adding default_nginx-secrets-store-inline-crd/7f0098aba9421d5a4fc9984d50db88905f1ee173acb296179156984faa73f423 to network azure-vnet/azure: A virtual machine or container with the specified identifier does not exist.
E0324 20:00:34.516993 4368 cni_windows.go:59] error while adding to cni network: A virtual machine or container with the specified identifier does not exist.
W0324 20:00:34.516993 4368 docker_sandbox.go:400] failed to read pod IP from plugin/docker: networkPlugin cni failed on the status hook for pod "nginx-secrets-store-inline-crd_default": A virtual machine or container with the specified identifier does not exist. I see in the logs that the csi driver is mounting correctly:
|
769fdc1
to
3c70752
Compare
3c70752
to
c2e0910
Compare
c2e0910
to
191786d
Compare
bba5984
to
795101c
Compare
/test pull-secrets-store-csi-driver-e2e-windows |
795101c
to
80a9686
Compare
/test pull-secrets-store-csi-driver-e2e-windows |
80a9686
to
52926a7
Compare
/test pull-secrets-store-csi-driver-e2e-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Windows grpc connections are currently broken:
Believe this was caused by #462 where
grpc.Dial
was replaced withgrpc.DialContext
.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: