Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions for v0.0.22 #544

Merged
merged 1 commit into from May 17, 2021

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented May 17, 2021

What this PR does / why we need it:

Following release process at https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/master/docs/RELEASE.md#versioning to build v0.0.22

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2021
@aramase
Copy link
Member

aramase commented May 17, 2021

The windows job failed with image push to azure registry:

docker manifest inspect k8sprow.azurecr.io/driver:v0.1.0-e2e-6a34ce08
Get https://k8sprow.azurecr.io/v2/driver/blobs/sha256:337ee5bc56dc88cb1e6a3deb1149cef6a4c5686a435aa528419628796cabb599: dial tcp 20.44.11.2:443: i/o timeout
make[2]: *** [Makefile:234: push-manifest] Error 1
make[2]: Leaving directory '/home/prow/go/src/sigs.k8s.io/secrets-store-csi-driver'
make[1]: *** [Makefile:264: e2e-container] Error 2

restarting to check if it's a flake
/test pull-secrets-store-csi-driver-e2e-windows

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 66ecd75 into kubernetes-sigs:master May 17, 2021
@tam7t tam7t deleted the bump-version-v0.0.22 branch May 17, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants