-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give aws secret and parameter names uuid #569
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @lasred. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
objectType: "secretsmanager" | ||
- objectName: "SecretsManagerTest1" | ||
- objectName: "SecretsManagerTest1-${UUID}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just use $SM_TEST_1_NAME
instead of a constant + variable? Similar changes for all the objectName
in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup that would be cleaner
/ok-to-test |
33ddc7b
to
55d06d6
Compare
/retest |
Makefile
Outdated
@@ -98,6 +98,7 @@ SHELLCHECK_VER ?= v0.7.2 | |||
BUILD_TIMESTAMP_W_SEC := $(shell date +%Y-%m-%d-%H-%M-%S) | |||
EKS_CLUSTER_NAME := integ-cluster-$(BUILD_TIMESTAMP_W_SEC) | |||
AWS_REGION := us-west-2 | |||
AWS_TEST_UUID := $(shell openssl rand -hex 6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we set this variable in the bats test suite? Similar to
secrets-store-csi-driver/test/bats/azure.bats
Lines 19 to 21 in 8a9ccd1
if [ -z "$AUTO_ROTATE_SECRET_NAME" ]; then | |
export AUTO_ROTATE_SECRET_NAME=secret-$(openssl rand -hex 6) | |
fi |
I think we should avoid having all these defaults in the Makefile
and keep them in the script file or bats test file instead.
test/bats/aws.bats
Outdated
@@ -7,34 +7,46 @@ SLEEP_TIME=1 | |||
PROVIDER_YAML=https://raw.githubusercontent.com/aws/secrets-store-csi-driver-provider-aws/main/deployment/aws-provider-installer.yaml | |||
NAMESPACE=kube-system | |||
POD_NAME=basic-test-mount | |||
export REGION=us-west-2 | |||
export REGION=$REGION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
How about export REGION=${REGION:-us-west-2}
. By doing this we don't need to pass the REGION
in the e2e-aws
target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, lasred The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #568
Special notes for your reviewer: