Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arm64 build #575

Merged
merged 1 commit into from
Jun 8, 2021
Merged

feat: add arm64 build #575

merged 1 commit into from
Jun 8, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 2, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

What this PR does / why we need it:

  • Adds arm64 build for Linux images
  • Refactors dockerfile

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #525

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ritazh and tam7t June 2, 2021 20:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2021
aramase
aramase commented Jun 2, 2021
View reviewed changes
Makefile
@@ -54,7 +54,7 @@ export GOPATH GOBIN GO111MODULE DOCKER_CLI_EXPERIMENTAL

# Generate all combination of all OS, ARCH, and OSVERSIONS for iteration
ALL_OS = linux windows
ALL_ARCH.linux = amd64
ALL_ARCH.linux = amd64 arm64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding arm64 as a separate tag instead of using --platforms "linux/amd64, linux/arm64" with buildx to be consistent with current build tags for the driver driver:<tag>-<os>-<arch>

@aramase aramase force-pushed the multi-arch branch 2 times, most recently from 34af013 to f572f3b Compare June 2, 2021 20:53
@aramase aramase marked this pull request as ready for review June 2, 2021 21:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2021
@aramase
Copy link
Member Author

aramase commented Jun 2, 2021

Multi arch image build: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_secrets-store-csi-driver/575/pull-secrets-store-csi-driver-e2e-windows/1400193940635783168

@aramase
Copy link
Member Author

aramase commented Jun 2, 2021

cc @sozercan

@aramase aramase added this to the v0.0.23 milestone Jun 2, 2021
@aramase
Copy link
Member Author

aramase commented Jun 2, 2021

/retest

sozercan
sozercan reviewed Jun 2, 2021
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@aramase
feat: add arm64 build
6cf9e36 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase added this to In Review in Roadmap Jun 4, 2021
@tam7t
Copy link
Contributor

tam7t commented Jun 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@aramase
Copy link
Member Author

aramase commented Jun 8, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@k8s-ci-robot k8s-ci-robot merged commit f337632 into kubernetes-sigs:master Jun 8, 2021
@aramase aramase deleted the multi-arch branch June 8, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan left review comments

@ritazh ritazh Awaiting requested review from ritazh

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@tam7t tam7t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Roadmap
In Review
Milestone
v0.0.23
Development

Successfully merging this pull request may close these issues.

Support arm64
4 participants
@aramase @k8s-ci-robot @tam7t @sozercan