chore: set filtered-watch-secret to true by default for nodePublishSecretRef #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
What this PR does / why we need it:
filteredWatchSecret
by default fornodePublishSecretRef
. Starting fromv0.1.0
allnodePublishSecretRef
Kubernetes secrets need to be labelled withsecrets-store.csi.k8s.io/used=true
.v0.0.21
release, added to release notes forv0.0.22
andv0.0.23
.nodePublishSecretRef
not found to set the label on the Kubernetes secret.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):ref #550
Special notes for your reviewer: