Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e for --filtered-watch-secret=false #596

Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 15, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

What this PR does / why we need it:

  • Adds test for --filtered-watch-secret=false

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2021
@aramase
Copy link
Member Author

aramase commented Jun 15, 2021

/cc @nilekhc

@k8s-ci-robot
Copy link
Contributor

@aramase: GitHub didn't allow me to request PR reviews from the following users: nilekhc.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nilekhc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aramase
Copy link
Member Author

aramase commented Jun 15, 2021

/hold for #593 to be merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
@aramase
Copy link
Member Author

aramase commented Jun 15, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@nilekhc: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tam7t
Copy link
Contributor

tam7t commented Jun 16, 2021

To make sure I understand, filteredWatchSecret=true in the next release, but we want to make sure everything continues to work if everything is deployed with filteredWatchSecret=false?

Is there a targeted release where filteredWatchSecret=false will be unsupported?

@aramase
Copy link
Member Author

aramase commented Jun 16, 2021

To make sure I understand, filteredWatchSecret=true in the next release, but we want to make sure everything continues to work if everything is deployed with filteredWatchSecret=false?

That's right!

Is there a targeted release where filteredWatchSecret=false will be unsupported?

We'll make it unsupported in the release after. We'll deprecate the flag and remove it in future releases.

@tam7t
Copy link
Contributor

tam7t commented Jun 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit f430a74 into kubernetes-sigs:master Jun 16, 2021
@aramase aramase deleted the non-filtered-watch-test branch July 15, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants