-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removes local cache used for rotation #598
chore: removes local cache used for rotation #598
Conversation
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Hi @nilekhc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/test pull-secrets-store-csi-driver-e2e-azure |
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nilekhc The changes look good! We should also run load tests with the similar cluster setup as https://secrets-store-csi-driver.sigs.k8s.io/load-tests.html to document the memory consumption.
…-driver into rotation-upgrade
Load test result for top 5 CSI driver pods (without pprof enabled):
Load test result for top 5 CSI driver pods (with pprof enabled):
|
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, nilekhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com
What this PR does / why we need it:
This PR removes local informer cache used for rotation reconciler. Instead now it uses manager's cache.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #582
Special notes for your reviewer: