Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes local cache used for rotation #598

Merged
merged 16 commits into from
Jun 25, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Jun 16, 2021

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

What this PR does / why we need it:
This PR removes local informer cache used for rotation reconciler. Instead now it uses manager's cache.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #582

Special notes for your reviewer:

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nilekhc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 16, 2021
@nilekhc
Copy link
Contributor Author

nilekhc commented Jun 16, 2021

/cc @aramase @tam7t

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@nilekhc
Copy link
Contributor Author

nilekhc commented Jun 16, 2021

/test pull-secrets-store-csi-driver-e2e-azure

@aramase aramase added this to In Review in Roadmap Jun 17, 2021
@nilekhc nilekhc requested a review from aramase June 17, 2021 22:11
@aramase
Copy link
Member

aramase commented Jun 18, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 18, 2021
docs/book/src/topics/secret-auto-rotation.md Outdated Show resolved Hide resolved
pkg/k8s/store_test.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Outdated Show resolved Hide resolved
@nilekhc nilekhc requested a review from aramase June 18, 2021 22:22
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilekhc The changes look good! We should also run load tests with the similar cluster setup as https://secrets-store-csi-driver.sigs.k8s.io/load-tests.html to document the memory consumption.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2021
@nilekhc
Copy link
Contributor Author

nilekhc commented Jun 25, 2021

Load test result for top 5 CSI driver pods (without pprof enabled):

NAME                      CPU(cores)   MEMORY(bytes)   
csi-secrets-store-p2f92   2m           55Mi            
csi-secrets-store-9z7nm   2m           55Mi            
csi-secrets-store-k57d4   1m           54Mi            
csi-secrets-store-hmqzs   2m           54Mi            
csi-secrets-store-4lp76   2m           54Mi            

Load test result for top 5 CSI driver pods (with pprof enabled):

NAME                      CPU(cores)   MEMORY(bytes)
csi-secrets-store-54sxr   2m           59Mi
csi-secrets-store-hhqc5   2m           59Mi
csi-secrets-store-kx77t   2m           59Mi
csi-secrets-store-994xs   2m           58Mi
csi-secrets-store-fm25p   2m           58Mi

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2021
@nilekhc nilekhc requested a review from aramase June 25, 2021 17:40
@tam7t
Copy link
Contributor

tam7t commented Jun 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 181f3bd into kubernetes-sigs:master Jun 25, 2021
@nilekhc nilekhc deleted the rotation-upgrade branch June 25, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Roadmap
In Review
Development

Successfully merging this pull request may close these issues.

Upgrade to controller-runtime v0.9.0
4 participants