Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements e2e upgrade test #602

Merged
merged 22 commits into from
Jul 13, 2021
Merged

feat: implements e2e upgrade test #602

merged 22 commits into from
Jul 13, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Jun 21, 2021

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

What this PR does / why we need it:

This PR adds e2e upgrade (Released version -> manifest_staging version) test

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #457

Special notes for your reviewer:

@nilekhc
feat: implements e2e upgrade test
2430a00 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nilekhc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2021
@nilekhc
chore: waits 5m to create e2e kind cluster
0e0b879 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@aramase aramase added this to In progress in Roadmap Jun 23, 2021
@nilekhc
test: non kind bootstrap
ff45ce5 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
test: adds cleanup
be48ae4 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Merge branch 'master' of https://github.com/nilekhc/secrets-store-csi…
ebe3b59 
…-driver into e2e-upgrade-test
@nilekhc
test: adds e2e-test-bootstrap target for testing
79429d4 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
fix: azure bats file
51fbcc8 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
test: helm chart value at runtime
0f375c7 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2021
@nilekhc
fix: updates upgrade target
9d2adf2 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2021
@nilekhc
test: reuses helm values
8298dc1 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
test: adds crd upon helm upgrade
2dcfdd8 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
fix: upgrade test
9bfeffb 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
fix: updates upgrade target
93476e3 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
fix: removes wait to unblock
b2bf2aa 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
fix: updates crd path
68ca1bc 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
test: adds teardown method
5877dd4 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
test: removes test target
d19cdc7 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc marked this pull request as ready for review June 25, 2021 00:44
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2021
@nilekhc
Merge branch 'master' of https://github.com/nilekhc/secrets-store-csi…
3fa8105 
…-driver into e2e-upgrade-test
@nilekhc
chore: adds newline
22e27ad 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Jul 8, 2021

/retest

@nilekhc
test: fixes empty condition
f5ea16d 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc requested a review from tam7t July 8, 2021 23:45
aramase
aramase reviewed Jul 12, 2021
View reviewed changes
Makefile Outdated
@@ -349,6 +349,11 @@ e2e-helm-deploy:
--set enableSecretRotation=true \
--set rotationPollInterval=30s

.PHONY: e2e-helm-upgrade
e2e-helm-upgrade:
helm upgrade csi-secrets-store manifest_staging/charts/secrets-store-csi-driver --namespace kube-system --reuse-values --timeout=15m -v=5 --debug --set filteredWatchSecret=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the e2e image tag and set the linux and windows images here? --reuse-values without that will use the release image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh.. Good catch..

@nilekhc
test: sets docker images in helm upgrade
14c3eda 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc requested a review from aramase July 12, 2021 18:30
@nilekhc
Copy link
Contributor Author

nilekhc commented Jul 12, 2021

/retest

Error while creating Windows cluster

aramase
aramase reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
@aramase
Copy link
Member

aramase commented Jul 12, 2021

@nilekhc Could you rebase this PR to include the windows e2e changes I merged to master? That should provide a more consistent e2e test result.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
aramase
aramase reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
@tam7t
Copy link
Contributor

tam7t commented Jul 13, 2021

/lgtm

@tam7t
Copy link
Contributor

tam7t commented Jul 13, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilekhc, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit c43608c into kubernetes-sigs:master Jul 13, 2021
@nilekhc nilekhc deleted the e2e-upgrade-test branch July 13, 2021 16:53
This was referenced Jul 20, 2021
Closed
Closed
@nilekhc nilekhc mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh left review comments

@aramase aramase aramase left review comments

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@tam7t tam7t

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Roadmap
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upgrade to e2e
5 participants
@nilekhc @k8s-ci-robot @aramase @tam7t @ritazh