e2e: use kubectl wait to check if pods ready #628
Conversation
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
k8s-ci-robot
added
approved
| @@ -55,17 +54,15 @@ teardown_file() { | |||
| run kubectl --namespace $NAMESPACE apply -f $PROVIDER_YAML | |||
| assert_success | |||
|
|
|||
| cmd="kubectl --namespace $NAMESPACE wait --for=condition=Ready --timeout=60s pod -l app=csi-secrets-store-provider-aws" | |||
| wait_for_process $WAIT_TIME $SLEEP_TIME "$cmd" | |||
| kubectl --namespace $NAMESPACE wait --for=condition=Ready --timeout=120s pod -l app=csi-secrets-store-provider-aws | |||
There was a problem hiding this comment.
How to we arrive at timeout of 120s? I see 60s in some places. Is it based on past test runs?
There was a problem hiding this comment.
The 120s timeout is only for the provider image pulls because the image size isn't consistent for all providers. For the e2e cluster the image has to be pulled the 1st time and can take time. For the e2e test image, the image is small and the subsequent tests use IfNotPresent in the pod spec. So 60s for the e2e pods is ample time for the provider to fetch content from external secrets store and driver to complete mount.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, nilekhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
What this PR does / why we need it:
Only relies on
kubectl waitto check if the pod is ready as part of the e2e. Usingwait_for_processin addition tokubectl waitwill lead the tests to timeout. This change will make the tests fail fast.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: