Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove csi-common package and update driver #702

Merged
merged 1 commit into from Aug 20, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 20, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

What this PR does / why we need it:

  • Removes csi-common which had redundant implementation
  • Refactors driver initialization and cleans up ControllerServer implementation. The ControllerServer was solely implemented for the sanity tests and is an overhead to maintain as we update to newer versions of the CSI spec and tests.
  • Bumps versions for packages:
    • github.com/container-storage-interface/spec v1.5.0
    • github.com/kubernetes-csi/csi-lib-utils v0.10.0
    • github.com/kubernetes-csi/csi-test/v4 v4.2.0
  • Skips ControllerServer tests and other dependent tests in sanity test run.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 20, 2021
@aramase
Copy link
Member Author

aramase commented Aug 20, 2021

/test pull-secrets-store-csi-driver-build
/test pull-secrets-store-csi-driver-lint
/test pull-secrets-store-csi-driver-sanity
/test pull-secrets-store-csi-driver-unit

@aramase
Copy link
Member Author

aramase commented Aug 20, 2021

/test pull-secrets-store-csi-driver-build
/test pull-secrets-store-csi-driver-lint
/test pull-secrets-store-csi-driver-sanity
/test pull-secrets-store-csi-driver-unit

@aramase
Copy link
Member Author

aramase commented Aug 20, 2021

/test pull-secrets-store-csi-driver-e2e-vault

@aramase
Copy link
Member Author

aramase commented Aug 20, 2021

/test pull-secrets-store-csi-driver-e2e-azure
/test pull-secrets-store-csi-driver-e2e-gcp

@aramase
Copy link
Member Author

aramase commented Aug 20, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@aramase aramase marked this pull request as ready for review August 20, 2021 16:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2021
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@tam7t
Copy link
Contributor

tam7t commented Aug 20, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit d3873f5 into kubernetes-sigs:master Aug 20, 2021
@aramase aramase deleted the update-csi branch August 20, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants