New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove csi-common package and update driver #702
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-secrets-store-csi-driver-build |
/test pull-secrets-store-csi-driver-build |
/test pull-secrets-store-csi-driver-e2e-vault |
/test pull-secrets-store-csi-driver-e2e-azure |
/test pull-secrets-store-csi-driver-e2e-windows |
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
/lgtm |
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
What this PR does / why we need it:
csi-common
which had redundant implementationControllerServer
implementation. TheControllerServer
was solely implemented for the sanity tests and is an overhead to maintain as we update to newer versions of the CSI spec and tests.github.com/container-storage-interface/spec v1.5.0
github.com/kubernetes-csi/csi-lib-utils v0.10.0
github.com/kubernetes-csi/csi-test/v4 v4.2.0
ControllerServer
tests and other dependent tests in sanity test run.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: