BUG 2082099: Fix finalizer string too long

[Vincent056]

/kind bug

What this PR does / why we need it:

This PR shorten the finalizer string if it is over the limit size of 63

Does this PR have test?

Yes

Does this PR introduce a user-facing change?

No

Fix the finalizer string too long, shorten the length of the node name if the finalizer string combined length is over the size of 63

####Which issue(s) this PR fixes:

Fixes: BZ 2082099

[k8s-ci-robot]

Hi @Vincent056. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saschagrunert]

/ok-to-test

Thank you for the fix @Vincent056!

[saschagrunert]

We can make it a const to fix the CI.

[jhrozek]

An e2e test would also be nice.

[jhrozek]

just some nits

[jhrozek]

This is a complete nit, but can you change a comment to include that the finalizer can be up to 63 chars in lenght and 55 + len("-deleted") = 63? We might also want to use a constant instead of -deleted so that both are next to each other.

[jhrozek]

yup, validation error

[jhrozek]

internal/pkg/nodestatus/nodestatus_test.go:23: File is not `gci`-ed with --skip-generated -s standard,default,prefix(sigs.k8s.io/security-profiles-operator) (gci)
	"github.com/stretchr/testify/require"

So far I've had the best results with fixing the gci issues by running gci manually, something like:

go install github.com/daixiang0/gci@latest
gci write path/to/file

There is also the -l option that allows you to specify "local" imports that should be sorted last, but I could never get the flag combination to work, so I sort them manually. Normally the SPO expects the imports to be sorted:

• stdlib, alphabetically
• third party, alphabetically
• local, alphabetically

internal/pkg/nodestatus/nodestatus_test.go:60: File is not `gofumpt`-ed (gofumpt)

/build/golangci-lint run --fix --build-tags no_bpf should do the trick

Don't forget to remove and reinstall golangci-lint if you have an old version locally.

[Vincent056]

@jhrozek It seems like t.Parallel called after t.Setenv; cannot set environment variables in parallel tests [recovered], and not setting parallel is causing verify to fail

[jhrozek]

@jhrozek It seems like t.Parallel called after t.Setenv; cannot set environment variables in parallel tests [recovered], and not setting parallel is causing verify to fail

Can you try adding //nolint:paralleltest with the explanation you used to suppress the warning? There are some other uses of this stanza in SPO, you can git grep for its usage to see exactly where and how it's used.

[jhrozek]

/lgtm
I restarted the flatcar test, the failure looks like a install-time fluke

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhrozek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment