-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppArmor recorder: do not include CAP_OPT_NOAUDIT events #2274
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
- Coverage 45.50% 41.80% -3.70%
==========================================
Files 79 109 +30
Lines 7782 15542 +7760
==========================================
+ Hits 3541 6497 +2956
- Misses 4099 8569 +4470
- Partials 142 476 +334 |
efc26d4
to
8abd596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm
/test all |
@mhils may I ask you to rebase? |
this ensures that we do not end up with unused (sensitive) permissions in the profile
Done! Still based on the OLM PR so that CI turns green. :) |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This ensures that we do not end up with unused (sensitive) permissions in the profile.
Which issue(s) this PR fixes:
None
Does this PR have test?
Yes.
Special notes for your reviewer:
Does this PR introduce a user-facing change?