Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile recording 'kind' field #256

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Target of this field is to support additional profile types in the
future. We now also re-structure the project a bit to reflect which
parts are intended to be generic (binding/recording) and specific to a
certain technology (seccomp/selinux/apparmor).

Which issue(s) this PR fixes:

Refers to #46

Does this PR have test?

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Target of this field is to support additional profile types in the
future. We now also re-structure the project a bit to reflect which
parts are intended to be generic (binding/recording) and specific to a
certain technology (seccomp/selinux/apparmor).

Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2021
@JAORMX
Copy link
Contributor

JAORMX commented Feb 2, 2021

/lgtm

And thanks for the cleanup on the seccomp profile controller package!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0566d98 into kubernetes-sigs:master Feb 2, 2021
@saschagrunert saschagrunert deleted the recording-kind branch February 2, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants