Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selinux: Use events in the selinux controller #337

Merged
merged 1 commit into from Apr 23, 2021
Merged

selinux: Use events in the selinux controller #337

merged 1 commit into from Apr 23, 2021

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Mar 3, 2021 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR decorates the selinux policy controller with events so that the
administrator can better watch what is going on with the policies.

Which issue(s) this PR fixes:

Fixes #225

Does this PR have test?

N/A

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jhrozek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2021
@jhrozek jhrozek force-pushed the selinux_events branch 2 times, most recently from 092b115 to d3a9436 Compare March 3, 2021 13:12
@JAORMX
Copy link
Contributor

JAORMX commented Mar 3, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2021
@JAORMX
Copy link
Contributor

JAORMX commented Mar 3, 2021

/ok-to-test

JAORMX
JAORMX approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@JAORMX
Copy link
Contributor

JAORMX commented Mar 3, 2021

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@JAORMX
Copy link
Contributor

JAORMX commented Mar 3, 2021

/hold

We might need to further work on this. We're seeing a lot of conflicts due to each daemon instance running the reconciler

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2021
cmurphy
cmurphy reviewed Mar 22, 2021
View reviewed changes
Copy link
Contributor

@cmurphy cmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

internal/pkg/daemon/selinuxpolicy/selinuxpolicy_controller.go Outdated Show resolved Hide resolved
@jhrozek
selinux: Use events in the selinux controller
4f77785 
This PR decorates the selinux policy controller with events so that the
administrator can better watch what is going on with the policies.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@jhrozek
Copy link
Contributor Author

jhrozek commented Apr 19, 2021

/retest

@jhrozek
Copy link
Contributor Author

jhrozek commented Apr 19, 2021

ok, prow commands won't work for GH actions :-) and I can't find a re-run button in the UI so I'll just close and reopen the PR to force the actions again.
btw the test that failed was totally unrelated (profile recording)

@jhrozek jhrozek closed this Apr 19, 2021
@jhrozek jhrozek reopened this Apr 19, 2021
@jhrozek jhrozek closed this Apr 20, 2021
@jhrozek jhrozek reopened this Apr 20, 2021
@jhrozek jhrozek closed this Apr 22, 2021
@jhrozek jhrozek reopened this Apr 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #337 (4f77785) into master (7e8641f) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   38.08%   38.00%   -0.09%     
==========================================
  Files          20       20              
  Lines         948      950       +2     
==========================================
  Hits          361      361              
- Misses        572      574       +2     
  Partials       15       15

@saschagrunert
Copy link
Member

@jhrozek @JAORMX feel free to lift the hold if this can be merged.

@JAORMX
Copy link
Contributor

JAORMX commented Apr 23, 2021

/hold

Oh yeah, now that the status work merged the hold is not needed here anymore.

@JAORMX
Copy link
Contributor

JAORMX commented Apr 23, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 248bf2b into kubernetes-sigs:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmurphy cmurphy cmurphy left review comments

@JAORMX JAORMX JAORMX approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@JAORMX JAORMX

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selinux: Use events in the selinux controller
6 participants
@jhrozek @k8s-ci-robot @JAORMX @codecov-commenter @saschagrunert @cmurphy